crushlovely / ansible-unicorn-upstart Goto Github PK
View Code? Open in Web Editor NEWLicense: MIT License
License: MIT License
@pjkelly - Flagging this as an issue to allow us some more time to think about.
in general, this and the sidekiq roles look good. I have to call into question the variable naming though - these roles are making some general assumptions about how you configure your playbooks (with app_name, app_path, etc.), so I think explanation is warranted in the Readme about why it's setup this way. Thinking more long-term, having a general write-up on your variable strategy across roles and how it all fits together in the context of provisioning an application would be really nice to have.
The alternative here would be changing the variables in these two roles so they're a little more generic. e.g.
sidekiq:
conf_file: [full filename goes here]
app_path: [full path goes here]
...
unicorn:
conf_file: [full filename goes here]
app_path: [full path goes here]
Not saying you need to change your approach - just offering food for thought as someone who might want to use this role but doesn't understand the general strategy you're using.
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.