linux kernel 4.6.0 error about cryptodev-linux HOT 6 CLOSED

Please consider #14. I think it fixes the issue more thoroughly.

from cryptodev-linux.

@michaelweiser your suggested patch is equivalent except it brakes cryptodev on kernels that have no put_page (as suggested in the description on < 3.10 kernels )

from cryptodev-linux.

You misunderstood: I just stopped looking for when page_cache_release() was introduced and if it's always been an alias for put_page() because I thought 3.10 ancient enough. I've done some more checking: page_cache_release() has been an alias for put_page() since 2.6.0. Before that (at least as far back as 2.4.10) both page_cache_release() and put_page() have been an aliases for __free_page(), so will result in exactly the same code. Do we still support 2.2?

More importantly, I was actually referring to the use of get_user_pages_remote() because quite a lot of effort went into making parameters task and mm available at that point in the code. I guess there was a reason for that, namely accessing the memory of a task different from the current one after that task's decoupled/deferred asynchronous operation finished. If that's not the case, the whole handing-around of task and mm should be dropped as well, resulting in leaner function interfaces and data structures.

from cryptodev-linux.

Makes sense. The lowest kernel we support is 3.8 so that was my main concern. I will close this PR so you can make one. Thank you.

from cryptodev-linux.

Apologies, I thought this was the PR. Issue reopened, PR closed.

from cryptodev-linux.

Fixed in f14b470

from cryptodev-linux.