cryptonemo / rust-filcrypto-helpers Goto Github PK

Feedback from @porcuquine:

"One thing which would be useful are some test vectors so we know this primitive is behaving as expected — before relying on it to establish parity of spec and implementation.
Would be good to check a variety of preimage sizes — maybe all multiples of 32 below some N (@jake might have insight as to a good number).
We could be put the rust versions in the src, then assert same results in the Go tests.

On naming: can we use names which reflect the purpose — which is a minimal library of primitive on which specs tests can depend? From that perspective PedersenHashFFI is a funny name. The consumer of this pedersen hash shouldn't care that there's an FFI involved.Likewise, I would leave pedersen hash out of the name, since it will be misplaced if we add something else (as could well be needed).

The spec has a section for libraries, with filproofs being a child of filcrypto. (thinking…)
Maybe something like filcrypto-helpersor filcrypto-aux would work for these purposes."