Inconsistent results of `Crystal::ASTNode::Call#id` about crystal HOT 6 OPEN

The implementation should probably just delegate to #to_s.

I'm even wondering why we even have a separate #to_macro_id. Shouldn't #to_s always be correct?

from crystal.

#to_s would preserve e.g. the single or double quotation marks of a CharLiteral or StringLiteral, which we do not want.

from crystal.

Yeah right. Besides these exceptions?

from crystal.

But those exceptions are precisely why #to_s isn't "always" correct?

from crystal.

I mean for every other type than CharLiteral and StringLiteral, #to_macro_id could be identical to #to_s.

from crystal.

There is also SymbolLiteral#to_macro_id which drops the leading :. But I think the point is that the defined overloads avoid having to create a fresh Crystal::ToSVisitor every time ASTNode#id is called.

from crystal.