Giter VIP home page Giter VIP logo

Comments (2)

straight-shoota avatar straight-shoota commented on September 24, 2024

Thanks for digging into this 🫶

I'm wishing we'd implement more of these system functions in Crystal. It's nice and easy to use libc functions, but they have a complexity as well. And there are many pitfalls for using them correctly, demonstrated by the multiple different bugs we have identified in these relatively small pieces of code (#14619, #14615 and this one).
Of course, rolling our own implementation also adds complexity and we need to ensure correctness. We have some prior art to help with that though. And overall the implementations could end up simpler and more efficient. Looking up some string in /etc/passwd should be easy enough. And we only need to allocate memory for the field we're actually looking for.
Adding nscd might be a bit more complicated, although I'm wondering if that's even much useful anymore... We might just get away without it.

from crystal.

BlobCodes avatar BlobCodes commented on September 24, 2024

Adding nscd might be a bit more complicated, although I'm wondering if that's even much useful anymore... We might just get away without it.

I think /etc/passwd and /etc/groups will basically always fit into a single 4K memory page, so there's probably no difference to sending a lookup request to nscd over a unix socket (musl also only uses nscd as a fallback, so it's probably alright).

Manually implementing the file parsing also allows us to trivially implement methods like System::User#each.

from crystal.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.