Giter VIP home page Giter VIP logo

Comments (2)

kamil-gwozdz avatar kamil-gwozdz commented on August 23, 2024

I wrote a failing spec for it: kamil-gwozdz@bdc5756

I think the problem is that lines and @comment_columns are missmatched here:

max_column = nil
lines.each_with_index do |line, i|
comment_column = @comment_columns[i]?
if comment_column
if max_column
lines[i] = align_comment line, i, comment_column, max_column
else
max_column = find_max_column(lines, i + 1, comment_column)
lines[i] = align_comment line, i, comment_column, max_column
end
else
max_column = nil
end
end

# lines
["macro x", "end", "", "if true #", "  a = \"xy\" #", "end"] # 6 elements
# @comment_columns
[nil, nil, nil, nil, 8, 11, nil, nil] # 8 elements

I guess it's due to how macros are handled.

from crystal.

kamil-gwozdz avatar kamil-gwozdz commented on August 23, 2024

It seems like empty lines were removed from lines but they are still referenced in @comment_columns.

from crystal.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.