Giter VIP home page Giter VIP logo

Comments (4)

csernazs avatar csernazs commented on June 27, 2024 1

squash merging is already enabled. There are MRs where we want to keep the commits so I wouldn't force it.
I have also removed many branches, and enabled the Automatic delete options. I have some branches which aren't moving forward but I want to keep the contents in case I will have time to work on such as proxy support.

from pytest-httpserver.

beliaev-maksim avatar beliaev-maksim commented on June 27, 2024

@csernazs
basic rule is that each PR should be as small as possible and be self consistent. That leads to the situations that every PR could be and should be squashed.

You can take example of huge projects. CPython, Django, requests, etc

from pytest-httpserver.

csernazs avatar csernazs commented on June 27, 2024

We have small PRs but I like that PRs to have commits with descriptive commit messages such as in #166.
These PRs should not have been squashed, and I think it makes no sense to split this PR to 3 PRs.

Having one commit per PR is also fine and I have no problems if someone wants to squash the commits also (personally I prefer to tailor my commits in my git before pushing it to PR but YMMV).

from pytest-httpserver.

beliaev-maksim avatar beliaev-maksim commented on June 27, 2024

with above mentioned PR I would squash and merge together commit messages.
If commits could be separated as different features, then I would do 3 PRs out of 1.

I just share community standards, but it is up to the project to decide which way to go :)

from pytest-httpserver.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.