Comments (4)
squash merging is already enabled. There are MRs where we want to keep the commits so I wouldn't force it.
I have also removed many branches, and enabled the Automatic delete options. I have some branches which aren't moving forward but I want to keep the contents in case I will have time to work on such as proxy support.
from pytest-httpserver.
@csernazs
basic rule is that each PR should be as small as possible and be self consistent. That leads to the situations that every PR could be and should be squashed.
You can take example of huge projects. CPython, Django, requests, etc
from pytest-httpserver.
We have small PRs but I like that PRs to have commits with descriptive commit messages such as in #166.
These PRs should not have been squashed, and I think it makes no sense to split this PR to 3 PRs.
Having one commit per PR is also fine and I have no problems if someone wants to squash the commits also (personally I prefer to tailor my commits in my git before pushing it to PR but YMMV).
from pytest-httpserver.
with above mentioned PR I would squash and merge together commit messages.
If commits could be separated as different features, then I would do 3 PRs out of 1.
I just share community standards, but it is up to the project to decide which way to go :)
from pytest-httpserver.
Related Issues (20)
- Matching failure for expect_request HOT 2
- Extension for delayed matching and response HOT 7
- 1.0.4: sphinx fails because directories layout issue HOT 2
- 1.0.4: sphinx warnings `reference target not found` HOT 6
- howto response more than one cookie HOT 2
- Give a way to choose between listenning to IPV4 or IPV6 HOT 4
- Add client-side to the https code sample HOT 1
- Raise error if any request is received HOT 4
- Considering bringing plugin under pytest-dev HOT 2
- Add all the necessary imports in the code examples in the doc HOT 2
- Thread hang with hypothesis>=6.0.4 on Apple M1 Pro, Mac OS 12.6.2, Python>=3.10 HOT 11
- Can HTTPServer().handlers be modified from user code? HOT 3
- Recommendations for running both http (non-s) and https test within the same session HOT 2
- header auth matching breaks with Werkzeug>=2.3.0 HOT 5
- `werkzeug.urls` deprecation warnings with Werkzeug 2.3.0 HOT 2
- Twine dependency in 1.0.7 HOT 2
- Waiting without pytest and without starting the server HOT 6
- Async support? HOT 1
- MyPy complains when trying to update DEFAULT_MATCHERS HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pytest-httpserver.