cslant / lemp-docker Goto Github PK

It's necessary to change the configuration so that the latest PHP version will automatically be selected as the default value, not the current 8.2 version.

build:
      context: .
      dockerfile: ./docker/Dockerfile
      args:
          - PHP_VERSION_SELECTED=${PHP_VERSION_SELECTED:-8.2}
          - PHP_VERSION=${PHP_VERSION_SELECTED:-8.2}

Warning:

Node.js 12 actions are deprecated. Please update the following actions to use Node.js 16: docker/setup-buildx-action@v1, docker/login-action@v1, docker/metadata-action@v3, docker/build-push-action@v2. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/

I needed to update the compatible versions in the GitHub action to eliminate the above warning.

We need to re-optimize the Dockerfile for the purpose of reducing layers, the number of processes.

Same as this issue, I think we don't need to show all the Laravel sources in config docker!

Currently, the ports and app names in the docker-compose file are being called directly from the environment variables in the .env file.

This is very detrimental because in some cases users do not pay attention to this configuration request and ignore it to proceed with running the build command.
In that case, it will cause an error because the ports are unknown.

So I need a condition that if the environment variables do not exist, I will get the default port to avoid the above error.