Hello,

I am going the following error when trying to install from git.

All the best.

Best regards,

─ preparing 'csodata':
✔ checking DESCRIPTION meta-information ...
E checking vignette meta-information ...
Output(s) listed in 'build/vignette.rds' but not in package:
'inst/doc/quick_start_guide.html'
Run R CMD build without --no-build-vignettes to re-create
Error: Failed to install 'csodata' from GitHub:
! System command 'Rcmd.exe' failed
In addition: Warning messages:
1: In untar2(tarfile, files, list, exdir, restore_times) :
skipping pax global extended headers
2: In untar2(tarfile, files, list, exdir, restore_times) :
skipping pax global extended headers

Issue is occurring with the line print(sf::st_crs(shp)) The error given is

Error in st_crs.character(shp) : invalid crs: SF

where SF is the sf data frame.

The line does not cause an error when ran outside of the function.

As per r-lib/roxygen2#1491 some Roxygen changes are required.

Just a simple ease of use update to make table codes case insensitive.

Using the pivot_format = "tidy" parameter causes an error in cso_get_data().

The problem would appear to be with the line

data <- tidyr::pivot_wider(data, names_from = Statistic ,values_from = value)

as the variable value has been renamed to Value earlier.

Will continue to allow wide_format but will warn users it is deprecated

Warning periodically appears when using cso_get_table(). Believed to be linked to the cache but still investigating.

In addition: Warning messages:
1: In normalizePath(path.expand(path), winslash, mustWork) :
path[1]="path/to/ RCache": The system cannot find the file specified
2: In normalizePath(path.expand(path), winslash, mustWork) :

The flush_cache parameter appears not to work on linux for functions cso_get_data(), cso_get_geo() and cso_get_toc().

These functions contain the code paste0(R.cache::getCacheRootPath(),"\\csodata") when a call to file.path() might be preferable.

The LastModified column of the data.frame returned by cso_get_toc() contains some NA values. (All the values are NA when run on a linux machine.)

The 'Z' in the format = argument below may be the problem.

tbl3$LastModified <- as.POSIXct(tbl3$LastModified, format = "%Y-%m-%dT%H:%M:%SZ")

When the 'Z' is removed (format = "%Y-%m-%dT%H:%M:%S"), all the values appear in the data.frame.

Error due to incorrect API call when from_date = null.

Error in [.data.frame(tbl, c("link.item.updated", "link.item.label")) :
undefined columns selected

Setting include_ids = TRUE causes an error in cso_get_data().

Possibly:

   data_id <- rjstat::fromJSONstat(parse(json_data)$result, naming = "id", use_factors = use_factors)

should be changed back to:

    data_id <- rjstat::fromJSONstat(json_data, naming = "id", use_factors = use_factors   )

as in an earlier version of this package.

Hello,
I am pretty sure you are aware of the situation https://cran-archive.r-project.org/web/checks/2022/2022-07-19_check_results_csodata.html - just checking in.

Hi,
Using the latest cran csodata 1.4.2
Observed - request frequently times out with error message ' "Warning: Failed retrieving table of contents. Please check internet connection and that data.cso.ie is online"
Loaded cached data'

This is despite cso.data.ie being open in my browser, and the internet connection working well.
Eventually it will respond, but it can take several tries.

Some Issue with the County Council geographic data from cso_get_geo().

The following code:
cso_get_geo_meta(cso_get_geo("cc"))

when run results in the following error

Error in wk_handle.wk_wkb(wkb, s2_geography_writer(oriented = oriented,  : 
  Loop 50 is not valid: Edge 1391 has duplicate vertex with edge 1394

Unsure if issue with cso_get_geo_meta() or the sf dataframe itself. Will need to be investigated.

In 2019 Cork city expanded its boundary. The updated shape files showing the change can be seen on the cso website. This shape file cannot be currently retrieved through the cso_get_geo function.

This is just an example of an change that I have noticed but there may be more not reflected in the current shape files offered through cso_get_geo.

Encountered an issue where a user trying to download data was getting not up to date results due to PxStat being updated while package was retrieving the old version from the cache. Need to investigate possibly emptying the cache and downloading fresh data at certain times.

The shapefile dataset from cso_get_geo("la") seems to have some issues.