cxflag203 / cascadia Goto Github PK

for html: "<p></p>    <p></p>"
given selector: "p + p"
should get a <p> node, but got empty selection.

Attached file is the bug fix and updated unit test. Hope to help you.

What steps will reproduce the problem?
1. go get code.google.com/p/cascadia with a tip version of go fails

Error message is:

$ go get code.google.com/p/cascadia
# code.google.com/p/cascadia
/tmp/go/src/code.google.com/p/cascadia/selector.go:46: n.Child undefined (type 
*html.Node has no field or method Child)
/tmp/go/src/code.google.com/p/cascadia/selector.go:234: parent.Child undefined 
(type *html.Node has no field or method Child)
/tmp/go/src/code.google.com/p/cascadia/selector.go:279: parent.Child undefined 
(type *html.Node has no field or method Child)
/tmp/go/src/code.google.com/p/cascadia/selector.go:299: n.Child undefined (type 
*html.Node has no field or method Child)
/tmp/go/src/code.google.com/p/cascadia/selector.go:348: p.Child undefined (type 
*html.Node has no field or method Child)

What version of the product are you using? On what operating system?
go/ $ hg sum
parent: 14012:b8637622df90 tip
 exp/locale/collate/build: moved some of the code to the appropriate file, as
branch: default
commit: (clean)
update: (current)


Please provide any additional information below.
The attached patch gets tests passing again

As explained here: 
https://groups.google.com/forum/#!msg/golang-nuts/eD8dh3T9yyA/l5Ail-xfMiAJ

The code.google.com/p/go.xxx must be updated to use golang.org/x/xxx. This is 
currently blocking the import path updates for my goquery package. I would've 
liked to send a pull request instead of just logging an issue, but I'm not 
familiar enough with mercurial and google code's PR process.

Thanks,
Martin

Can you move this project to GitHub?
Google Code is shutting down.

http://code.google.com/p/go/source/detail?r=ffbff9f7596e2655eab581b0188ad2a02177
78f0&repo=net

Imports now should be:
"code.google.com/p/go.net/html"

Best regards,
Dobrosław Żybort

I expanded the selector set a bit and am submitting a patch in case you want to 
include any of it in the library.

If you see some issues, let me know. I more than happy to make changes.

And, btw, I've gotten a lot of use out of this library. Thank you for writing 
it! I basically think it's pretty awesome. 

What steps will reproduce the problem?
1. Try a CSS selector ":content"
2. Yields an error: unknown pseudoclass :content
3. Cry

What is the expected output? What do you see instead?

I'd like the :content pseudo class to be handled :)

What version of the product are you using? On what operating system?

Using through goquery, checked out a few moments ago.

Please provide any additional information below.

Should we change the sub-repository path?

sed -i 's|"code\.google\.com/p/go\.|"golang.org/x/|' $(find . -name '*.go')

https://groups.google.com/forum/#!topic/golang-nuts/eD8dh3T9yyA