Tests always expect Pacific time about scobot HOT 2 CLOSED

Hi Chris,
The js/test/scobot.js file is hardcoded. I thought about making it dynamically adjust itself but it wasn’t really a severe failing test. I have seen it fail while I travel to.

Thanks,
Mark

On Jun 18, 2014, at 11:34 PM, Chris Phillips [email protected] wrote:

Expected:

"Tue Mar 20 2012 10:47:54 GMT-0700 (PDT)"

Result:

"Tue Mar 20 2012 11:31:06 GMT-0500 (Central Standard Time)"

I'm in the central time zone. Are the tests hardcoded to pacific?

—
Reply to this email directly or view it on GitHub.

from scobot.

Hi,
Updated do effectively adjust your timezone with the fact its a PDT timestamp. It doesn't seem to cover all timezones however. I noted a 1 hour gap in Spain. But, again its mostly just a test to take a ISO8601 Time stamp in GMT or UTC and turn it into a Date Object. In most cases the SCO doesn't use this feature, however if you had something elaborate to do you may want to use a proven date conversion library like Moment.js or something else that can traverse Daylight Savings Time and tweaking timezones better.

from scobot.