cybroodoo / openhrmsenterprise Goto Github PK

Issues when generating payroll batch:

• Company is readonly on creation and selected the first company even if it's not active
• On generate: Error with overtime module (field singleton validation)
• On generate: Error with vacation module (field singleton validation)

Used module: ent_ohrms_overtime

When approving a hr.overtime request, one gets the following error: Incorrect state for new allocation
The error is caused by the creation of a new hr.leave.allocation on approving the hr.overtime. The hr.leave.allocation states that a new allocation should be in state draft of confirm.

if 'state' in values and values['state'] not in ('draft', 'confirm'): raise UserError(_('Incorrect state for new allocation'))
https://github.com/odoo/odoo/blob/d2db535ec10e24713fcc2329927ce080534346ce/addons/hr_holidays/models/hr_leave_allocation.py#L643

Proposed fix:
Change the state of the new allocation to 'draft' or 'confirm'.
And this on 2 lines:

1. OpenHrmsEnterprise/ent_ohrms_overtime/models/e_overtime_request.py

   Line 188 in d0f0ead

   'state': 'validate',

2. OpenHrmsEnterprise/ent_ohrms_overtime/models/e_overtime_request.py

   Line 199 in d0f0ead

   'state': 'validate',

In loan payroll calculation, the definition of rule LO works fine on a single salary structure, if defined on a second (i.e. Saudi and Expat), it works on the first one defined and the second fails on calculation with error:
Validation Error

The operation cannot be completed:

• Create/update: a mandatory field is not set.
• Delete: another model requires the record being deleted. If possible, archive it instead.

Model: Payslip Input (hr.payslip.input)
Field: Type (input_type_id)

Hi,

I installed the 16.0 version, and I get several WARNING, due to incomplete migration to 16.0

Field hr.lawsuit.court_name: unknown

• Field hr.contract.hourly_wage: unknown parameter 'digits', if this is an actual parameter you may want to override the method _valid_field_parameter on the relevant model in order to allow it
• Field hr.employee.family.birth_date: unknown parameter 'tracking', if this is an actual parameter you may want to override the method _valid_field_parameter on the relevant model in order to allow it
• hr.contract.state: selection=[('draft', 'New'), ('probation', 'Probation'), ('open', 'Running'), ('close', 'Expired'), ('cancel', 'Cancelled')] overrides existing selection; use selection_add
• Field hr.loan.state: unknown parameter 'track_visibility', if this is an actual parameter you may want to override the method _valid_field_parameter on the relevant model in order to allow it

Regards