Support multiple stream libraries about redux-cycles HOT 6 CLOSED

@goshakkk @nickbalestra I'm thinking of this:

// `Cycle` can be xstream or rxjs or anything else
var output = Cycle.run(main, { ACTION: makeActionDriver(), STATE: makeStateDriver() })
const cycleMiddleware = createCycleMiddleware(output);

Problem is that the ACTION driver needs access to store so we need to create the drivers in the middleware (as it is now).

Maybe we can just keep the API as it is, but add an extra arg to createCycleMiddleware which is the actual run method to use internally:

import {run} from '@cycle/xstream-run';
const cycleMiddleware = createCycleMiddleware(main, { HTTP: makeHTTPDriver() }, run);

Thoughts?

from redux-cycles.

The second one with passing run looks more appropriate.

One thing worth keeping in mind is the fact that Cycle might become xstream-only internally and will make users themselves responsible for converting sources from xstreams and sinks to xstream if they choose to use another library. It's not set in stone yet, of course, but here is the thread for reference: cyclejs/cyclejs#425

from redux-cycles.

from redux-cycles.

Interesting, does this mean that all drivers must be xstream compatible?

from redux-cycles.

@goshakkk it doesn't seem like Cycle will be xstream-only: https://gitter.im/cyclejs/cyclejs?at=585bcfc496a565f844067997

Unless I misunderstood what you were trying to say.

from redux-cycles.

Ah it seems that the only difference is that we won't have to use runStreamAdapter. But passing the run is something that we'll need to do in order to support other stream libs.

from redux-cycles.