Someone on gitter pointed out that hot reloading isn't possible with redux-cycles. We should have a solution for this. Tagging this as enhancement

Hi Luca,

as I've starting playing with your awesome project, I found myself using something similar to combineEpics&co. Here is how it looks like.

In the example you provided could be used like:

// inside redux-cycle-middleware/example/cycle/index.js
...
import { combineCycles } from 'redux-cycle-middleware'
...
function fetchReposByUser(sources) {...}
function searchUsers(sources) {...}
...
export default combineCycles(fetchReposByUser, searchUsers)

Let me know what you think, happy to open a PR if you feel like it will make sense to have it within redux-cycle-middleware

I'm a bit of a newb with package.json and npm stuff, but it doesn't seem right that xstream and run are inside devDependencies. For instance, the jsonp driver has xstream as a peerDependency and run as a dependency: https://github.com/Widdershin/cycle-core/blob/bbad3d6ef832e6131f1c81a32de856b3d56ecda2/jsonp/package.json#L12

@nickbalestra @goshakkk not sure how peerDependencies work but maybe you guys can help?

@goshakkk @lmatteis , I'm putting together some slides for a talk I'll be doing on redux-cycles, here a first draft. Would love to hear your feedbacks!

So I'd like to test the example project (which is meant to be a separate project with its own package.json) using travis. Any thoughts on configuring this? @nickbalestra

Hey,

it seems like there are typescript type definitions (see #37) but there are not added to the build and therefore not available when using this lib in your project without further ado.

Or am I missing something here? If not, I would happily provide a PR.

Best

There seems a steep drop off in activity as of late and open issues that seem a bit stale. Just curious as to how likely I would be to get help if I ended up using your seemingly wonderful library.

@goshakkk so I'm trying out your STATE extension but getting some odd behaviour: https://jsbin.com/kijucaw/6/edit?js,output

Try clicking the "odd +" button which triggers a read to the STATE stream. It doesn't work as expected and if you click it multiple times you get a Maximum call stack size exceeded error. I'll be looking into a fix for this.

I was thinking that perhaps rather than a STATE stream we could do it the way redux-observable does: pass in the store reference down the ACTION stream somehow, so we can call store.getState() inside the stream composition whenever it is needed.

When using this with create-react-native-app, I get some sort of TransformError. The error says that a "es2015" preset is not found relative to node_modules/redux-cycles/dist/index.js. I checked the package.json of this package and the babel configs are there. So I'm a bit unsure if the error is with the library or create-react-native-app.

ATM, I can get it to work by manually entering node_modules/redux-cycles/ and doing two things:

1. install deps: yarn install
2. adding a .babelrc that contains the preset "es2015"

Hi!

I've created some helpers, not sure if you need it in that repo:
https://gist.github.com/PEZO19/b85686552bc6c67829e7f123587e0688

@lmatteis if you think it's useful, I can make a PR.

I wanted to add some linting to the project, any suggestion/preferences? (my +1 goes for standard)

This is a spike to organize thoughts and resources relating to docs. (Feel free to tag this one as a to-do or something)

As someone who's tried several existing side-effect models for Redux and Cycle, the README was just enough for me to see what this is about. However, this is not going to be the case for everyone, therefore we should consider an effort to improve the docs.

Throwing a couple of my thoughts:

• identify target audiences: redux-saga and redux-observable users
• appeal to TAs individually: maybe have separate sections about redux-cycle vs saga and redux-cycle vs redux-observable. pros and cons, differences in approaches
• observables are typeable, whereas generators are hard to type (yield can't be typed. yield* can, but it can't be used in the catch/finally blocks, greatly limiting their usefulness — this is something I discovered making redux-typed-saga)
• briefly introduce observables and Cycle.js and link to the official docs and other useful resources
• page on side-effect handling. common scenarios
• encourage custom drivers for side-effects (analytics, native functionality, etc; whereas the official docs seem to kind of oppose them)
• commonly needed functionalities translated from pure react/sagas/observables to redux-cycle
• more examples
• GitHub pages to host the docs

Currently createCycleMiddleware() decides which stream library to use and it defaults xstream-run. It would be nice to allow users to select which run method to call, hence which stream library to use - and our driver internally should support most common stream libs using runStreamAdapter.

It is quite odd that this library written in JS because on the other side CycleJS is fully written in TypeScript. Would you mind to write TypeScript declarations?

Hi,

I got really interested in redux-cycles. But, I am new to streams. Is it possible to add a an example project where there will be multiple async actions in a queue?

For eg. upon selecting an item from the list, a popup displayed which shows different kinds of data about the item, in which each data is the result of an async action.

Thanks much.

@nickbalestra can you try running npm i and npm run test on the example folder (with a clean install). I'm getting a weird Error: Cannot find module '@cycle/time' error and can't figure out why since @cycle/time is right there in package.json :(

Hi guys
I upgraded to the latest version of @cycle/run and I'm getting schedulemicrotask is not a function
It doesn't happen with version "^3.0.0"

These are my dependencies:

This is the error:

As a n00b to this library and observables, it's not clear why a lot of the variables in the README's examples have dollar signs at the end of their names.

Explaining the convention would make your project more accessible.

(Following the links to other libraries cited is not helpful either: the first code examples given in the docs for both Cycle.js and redux-observable also introduce dollar-sign variables with no explanation.)

I have entered the code in the simplest "PING/PONG" example from README.md, but there seems to be no definition of rootReducer. Either the code is missing something or I am...

Keep getting compile errors and can't run the example app

Generic type 'Sources' requires 1 type argument(s).
Generic type 'Sinks' requires 1 type argument(s).

Hey glad to see someone finally open sourced this approach. Something I have found to typically be true when using this approach internally is that you need the state with the action. This is useful as you will want to select a piece of state to conditionally decide if enough effect should sink. For example, you may want to check if you already have state for a given api before requesting it from the api again.

I have a component that at componentDidMount will fire an action that makes an http request.
What I want is to set an isFetching flag in the reducer.
Everything works as expected the first time I load the component, but the second the flag isFetching is never set to true.
I played just a little with the middleware during this weekend so I'm not really sure why I have this problem.

This is my main, I just readapted the code from one of the example.

const fetchPostById = (sources) => {
  const post$ = sources.ACTION
    .filter(action => action.type === ActionTypes.POST_REQUESTED)
    .map(action => action.postId);

  const request$ = post$
    .map(postId => ({
      url: `${BASE_URL}posts/${postId}`,
      category: 'post'
    }));

  const response$ = sources.HTTP
    .select('post')
    .flatten();

  const action$ = xs.combine(post$, response$)
    .map(arr => actions.receivePostById(arr[0], arr[1].body));

  return {
    ACTION: action$,
    HTTP: request$
  }
}

And this is the reducer:

const post = (state = initialPost, action) => {
  switch (action.type) {
    case 'POST_REQUESTED':
      return {
        ...state,
        isFetching: true,
      };
    case 'POST_RECEIVED':
      return {
        ...state,
        isFetching: false,
        [action.postId]: action.post,
      };
    default:
      return state;
  }
};

If I log what's going on with my request, I can see that isFetching is false at the beginning, then the action POST_REQUESTED is fired and isFetching is set to true. When POST_RECEIVED is being fired (from the cycle code) isFetching goes back to false. That's the normal case.
On the next time POST_RECEIVED is being fired two times for the same action and isFetching flag is never set to true.

You can see an online version here https://dbertella.github.io/food-and-quote/ in case.
Am I missing something?

I was trying to use WebpackBin but it doesn't seem to be able to resolve our module: http://www.webpackbin.com/VJLpzPYdz

Might there be something wrong with the way we package it?