cyclopsmc / commoncapabilitiesapi Goto Github PK

View Code? Open in Web Editor NEW

6.0 6.0 3.0 242 KB

The public API for CommonCapabilities

License: MIT License

Java 100.00%

forge java minecraft

commoncapabilitiesapi's People

Contributors

Stargazers

Watchers

Forkers

way2muchnoise josephcsible tomylobo

commoncapabilitiesapi's Issues

Predicate in slotless item handler for insertion and extraction

Null pointer exception in ItemMatch.java

When org.cyclops.commoncapabilities.api.capability.itemhandler.ItemMatch.areItemStackTagsEqualis passed arguments such that a.getTagCompound() != null && b.getTagCompound() == null this results in NBT_COMPARATOR.compare being called with a null argument, which it does not support and leads to a null pointer exception followed by a crash.

Add blacklist flag to itemstack matchers

This should invert the complete matcher semantics.

Name "hash" is misleading

CommonCapabilitiesAPI/capability/inventorystate/IInventoryState.java

Lines 14 to 16 in 6fb398a

  * If inventory contents change, this method is guaranteed to return a different result. 

  * A different hash does however not necessarily guarantee an inventory change 

  * but it should in most cases since callers might gate expensive logic behind hash changes.

In general, hashes are guaranteed to be the same if the underlying state is the same, but not guaranteed to be different if the underlying state is different. We're asking for the exact opposite of this here. To avoid confusion, we should probably rename this to "nonce" or "revision ID" or something else that's not "hash". (Obviously, changing the method name is a breaking change that needs to wait for 1.13, but the comment can be reworded any time.)

Freshly built Energy Batteries aren't handled very well

Sometimes the Storage Terminal doesn't show them
If it does show them, it doesn't allow extracting them
When creating a recipe for them using the JEI recipe transfer feature (the little "+" button), that recipe cannot be crafted:
When crafting a manually created recipe, the system doesn't recognize the result
Crafting chains involving those batteries are nearly impossible to make due to this

I did some analysis with CraftTweaker's "/ct nbt" command and the difference between the recipes created manually and using JEI recipe transfer is this:
JEI recipe transfer:

{
    _type: "valuetype",
     typeName: "valuetype.valuetypes.integrateddynamics.recipe.name",
     _id: 256,
     value: "{output:{\"minecraft:itemstack\":[{id:\"integrateddynamics:energy_battery\",Count:1b,Damage:0s}]},input:{\"minecraft:itemstack\":[{val:[{condition:3,prototype:{id:\"integrateddynamics:crystalized_menril_chunk\",Count:1b,Damage:0s}}],type:0b},{val:[{condition:3,prototype:{id:\"integrateddynamics:crystalized_menril_block\",Count:1b,Damage:0s}}],type:0b},{val:[{condition:3,prototype:{id:\"integrateddynamics:crystalized_menril_chunk\",Count:1b,Damage:0s}}],type:0b},{val:[{condition:3,prototype:{id:\"integrateddynamics:crystalized_menril_chunk\",Count:1b,Damage:0s}}],type:0b},{val:[{condition:3,prototype:{id:\"minecraft:redstone_block\",Count:1b,Damage:0s}}],type:0b},{val:[{condition:3,prototype:{id:\"integrateddynamics:crystalized_menril_chunk\",Count:1b,Damage:0s}}],type:0b},{val:[{condition:3,prototype:{id:\"integrateddynamics:crystalized_menril_chunk\",Count:1b,Damage:0s}}],type:0b},{val:[{condition:3,prototype:{id:\"integrateddynamics:crystalized_menril_block\",Count:1b,Damage:0s}}],type:0b},{val:[{condition:3,prototype:{id:\"integrateddynamics:crystalized_menril_chunk\",Count:1b,Damage:0s}}],type:0b}]}}"
}

manually created:

{
    _type: "valuetype",
     typeName: "valuetype.valuetypes.integrateddynamics.recipe.name",
     _id: 759,
     value: "{output:{\"minecraft:itemstack\":[{id:\"integrateddynamics:energy_battery\",Count:1b,tag:{},Damage:0s}]},input:{\"minecraft:itemstack\":[{val:[{condition:3,prototype:{id:\"integrateddynamics:crystalized_menril_chunk\",Count:1b,Damage:0s}}],type:0b},{val:[{condition:3,prototype:{id:\"integrateddynamics:crystalized_menril_block\",Count:1b,Damage:0s}}],type:0b},{val:[{condition:3,prototype:{id:\"integrateddynamics:crystalized_menril_chunk\",Count:1b,Damage:0s}}],type:0b},{val:[{condition:3,prototype:{id:\"integrateddynamics:crystalized_menril_chunk\",Count:1b,Damage:0s}}],type:0b},{val:[{condition:3,prototype:{id:\"minecraft:redstone_block\",Count:1b,Damage:0s}}],type:0b},{val:[{condition:3,prototype:{id:\"integrateddynamics:crystalized_menril_chunk\",Count:1b,Damage:0s}}],type:0b},{val:[{condition:3,prototype:{id:\"integrateddynamics:crystalized_menril_chunk\",Count:1b,Damage:0s}}],type:0b},{val:[{condition:3,prototype:{id:\"integrateddynamics:crystalized_menril_block\",Count:1b,Damage:0s}}],type:0b},{val:[{condition:3,prototype:{id:\"integrateddynamics:crystalized_menril_chunk\",Count:1b,Damage:0s}}],type:0b}]}}"
}

The only difference between them is the tag:{}, in the output.

I think JEI just enters what it sees in the actual recipe definition as the output, whereas any actually existing battery would already have the empty tag in place.

Proposed solution:

Make the recipe create a battery with the "energy" tag already initialized to 0, thus avoiding confusing between having an empty tag container and no tag container
For good measure, ensure that JEI-cheated items also contain that tag

matchFlags should be used

Cause now it doesn't even matter what I pass :p

@Override
public ItemStack extractItem(@Nonnull ItemStack matchStack, int matchFlags, boolean simulate) {
    int slot = getNonEmptySlotWithItemStack(matchStack, ItemMatch.DAMAGE | ItemMatch.NBT);
    if (slot < 0) return null;
    return itemHandler.extractItem(slot, matchStack.stackSize, simulate);
}

https://github.com/CyclopsMC/CommonCapabilitiesAPI/blob/master-1.9/capability/itemhandler/SlotlessItemHandlerWrapper.java#L68

Recommend Projects

React

A declarative, efficient, and flexible JavaScript library for building user interfaces.
Vue.js

🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
Typescript

TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
TensorFlow

An Open Source Machine Learning Framework for Everyone
Django

The Web framework for perfectionists with deadlines.
Laravel

A PHP framework for web artisans
D3

Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

javascript

JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
web

Some thing interesting about web. New door for the world.
server

A server is a program made to process requests and deliver data to clients.
Machine learning

Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Visualization

Some thing interesting about visualization, use data art
Game

Some thing interesting about game, make everyone happy.

Recommend Org

Facebook

We are working to build community through open source technology. NB: members must have two-factor auth.
Microsoft

Open source projects and samples from Microsoft.
Google

Google ❤️ Open Source for everyone.
Alibaba

Alibaba Open Source for everyone
D3

Data-Driven Documents codes.
Tencent

China tencent open source team.

	* If inventory contents change, this method is guaranteed to return a different result.
	* A different hash does however not necessarily guarantee an inventory change
	* but it should in most cases since callers might gate expensive logic behind hash changes.