Giter VIP home page Giter VIP logo

Comments (3)

immortaleeb avatar immortaleeb commented on July 17, 2024

I tried this in a separate branch: https://github.com/CyclopsMC/FluidConverters/tree/recipes
The biggest problem that keeps it from working is the fact that fluid groups are loaded on postInit, while recipes are loaded somewhere in on Init.

The way I see it there are 2 possible fixes:

  1. Move parsing of fluid group configs before recipe loading, and only load the actual fluid groups (i.e. find fluids in the registry) after all recipes are loaded. The problem is that this could potentially register recipes for fluid converters that appear to be invalid fluid converters later due to e.g. the fluids in the fluid elements being ignored.
  2. Ignore recipe loading in init step and/or (re)trigger recipe loading after postInit (i.e. after loading the fluid groups).

from fluidconverters.

rubensworks avatar rubensworks commented on July 17, 2024

I would try to move recipes loading to postInit (on CyclopsCore level).
Before making the actual change, look if this doesn't break anything, EvilCraft should be the first mod to show any signs of breakage.

from fluidconverters.

immortaleeb avatar immortaleeb commented on July 17, 2024

Added in 6174b9d

from fluidconverters.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.