Comments (3)
I tried this in a separate branch: https://github.com/CyclopsMC/FluidConverters/tree/recipes
The biggest problem that keeps it from working is the fact that fluid groups are loaded on postInit, while recipes are loaded somewhere in on Init.
The way I see it there are 2 possible fixes:
- Move parsing of fluid group configs before recipe loading, and only load the actual fluid groups (i.e. find fluids in the registry) after all recipes are loaded. The problem is that this could potentially register recipes for fluid converters that appear to be invalid fluid converters later due to e.g. the fluids in the fluid elements being ignored.
- Ignore recipe loading in init step and/or (re)trigger recipe loading after postInit (i.e. after loading the fluid groups).
from fluidconverters.
I would try to move recipes loading to postInit (on CyclopsCore level).
Before making the actual change, look if this doesn't break anything, EvilCraft should be the first mod to show any signs of breakage.
from fluidconverters.
Added in 6174b9d
from fluidconverters.
Related Issues (20)
- Don't reinvent the wheel HOT 1
- Null pointers in packet handling when placing fluid converter HOT 1
- Before 1.0 HOT 1
- Add support for lossRatio and hasRecipe
- Port fluid retrieval command HOT 1
- Add support for JEI HOT 4
- Fluid Converters always white HOT 1
- [1.10.2] Recipe for Fluid Converter missing in JEI HOT 5
- Nullpointer on invalid fluid converter v2.2.0
- Evilcraft blood to Life essence HOT 4
- Fluid transfer stopping HOT 35
- Crash during startup: NullPointerException: Rendering ingredient HOT 2
- [1.12] Default recipe missing HOT 2
- Converter stop to working as soon as the output is full HOT 3
- [1.12.2] Bug: Wrong behaviour? HOT 1
- Doesn't work after Forge/Java update HOT 6
- You have to mark either the north and west faces to get any output HOT 3
- [1.7.10] What Should I do to make fluid converters work with Mekanism Liquids HOT 2
- Steam from different mods HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from fluidconverters.