cyclopsmc / integratedterminals-compat Goto Github PK

Issue type:

• ➕ Feature request
  I'm not sure if this counts as a feature request 😅

---

Short description:

TerminalStorageGuiHandler uses some JEI API functions that were deprecated and have been removed in the 1.19.4 version. Specifically IGuiContainerHandler#getIngredientUnderMouse and IIngredientManager#getIngredientType.

I'd be happy to bring the TerminalStorageGuiHandler up to speed with the JEI API if needed 👍

Issue type:

• 🐛 Bug

---

Short description:

Crash that happens only when I enable "IntegratedTerminals-Compat", all other "integrated" mods seems to be fine.
Details here:
https://paste.ee/p/Nx43I

Steps to reproduce the problem:

1. Install mods listed in log
2. run
3. crash

Expected behaviour:

1. Install mods listed in log
2. run
3. no crash

---

Versions:

• This mod: 1.15.2-1.0.14
• Minecraft: 1.15.2
• Forge: 31.2.36

Log file:

https://paste.ee/p/Nx43I

Issue type:

• 🐌 Performance issue

---

Short description:

When playing large mod packs and having a lot of items stored in the network, the JEI transferRecipe compat will overload the client.

Steps to reproduce the problem:

1. Install way too many mods
2. Get your storage full of different items
3. Press 'u' in JEI on a common item
4. The longer the recipe list the more load on the client.

Here's an example of a list with 12 pages of recipes (I pressed 'u' on planks):

---

Versions:

• This mod: 1.0.0
• Minecraft: 1.19.2
• Forge: 43.2.6

---

Proposed solution:

I'm already looking into making a PR for this and the problem lies here. The transferRecipe method is called every tick for every recipe in the JEI recipe list. Thus the cache stops working with >1 recipes in the list.

The question is now should I implement a more sophisticated cache or just add a config option to disable recipe transfer?