Giter VIP home page Giter VIP logo

cynkratemplate's People

Contributors

christophsax avatar indrajeetpatil avatar krlmlr avatar maelle avatar pat-s avatar

Stargazers

 avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Forkers

benubah

cynkratemplate's Issues

Fonts

I see Frutiger in Safari but not in the other browsers. I force reloaded, so I don't think it is a caching issue.

It looks so much smoother, so it would be nice if we could get this running everywhere.

image

Colors for hovers and active items

Would be good to align colors to "cynkrablue" across the theme. It might be that "cynkrablue" won't be a good choice for all instances but to me the light purple doesn't match well with "cynkrablue".

Here are some suggestions:

image

image

Simplify inclusion

The README mentions the need to add a custom in_header setting. The tidytemplate has a very similar description, though.

Can we automate this, even only with a use_cynkratemplate() function?

use BS5

in particular it'd add a search bar

CORS problems

Related to #20

@pat-s is there something that needs to be changed in the S3 bucket to allow cynkra.github.io/ to access the font files?

Logo in navbar

Do not use a logo, use cynkra text + a dot as on cynkra.com (it'll probably work without needing to add CSS rules since we already have those for the footer).

analytics

what kind of traffic analytics does cynkra use?

Tweak font access again

@pat-s when cynkratemplate has a cynkra.com subdomain, the font could again be accessed from cynkra dot com subdomains only.

Second menu row

without a sticky menu first. The first row should match the original header row on the website, the second row should be the "normal" pkgdown header.

Screenshot from 2021-05-20 08-29-40

Spacing between logo and package name

Looks a bit small. Should we increase it?

Instead of a 5px padding (current state) a padding of 20px looks decent?

#cynkra-logo-nav {
    height: 25px;
    padding-right: 20px;
    padding-bottom: 2px;
}

I also feel that a slight left padding (e.g. 2px) to the logo in the footer would smoothen things a bit.

#cynkra-logo-footer {
    height: 20px;
    padding-bottom: 2px;
    padding-left: 2px;
}

menu style tweaks

image

Could we have:

  • The logo fixed: dot is too big (as on cynkra.com)
  • The font of the 'reference' non-italic, as on the right?
  • Perhaps all menu fonts capitalized, as on cynkra.com (no strong opinion here)
  • Have you tried to have the menu without the shadow, as on cynkra.com, and a bit taller? I think the shadow is a non-flat element which we don't use otherwise. It may look a bit cleaner without it. But then there may be also too much white then.

BS5 TODOS

  • Get svg icon
  • Check with other visual identity criteria
  • Add a dropdown menu to see how it looks like / should be tweaked

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.