Giter VIP home page Giter VIP logo

golang-tmdb's Introduction

Software Engineer / Teacher

Linkedin Badge

Hi there! Feel free to message me :)

I love Linux, C++, Go and Open Source. Currently learning Rust and Haskell. Click here to check my CV.

golang-tmdb's People

Contributors

allanpk716 avatar brkyunlu avatar cevatbarisyilmaz avatar cyruzin avatar dimuska139 avatar example avatar jlucktay avatar kalafut avatar labulakalia avatar maddox avatar onlylty avatar rohfle avatar rqphqel avatar scafarella avatar tim-koehler avatar tmm1 avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar

golang-tmdb's Issues

Ability to modify http.Client or at least http.Client.Transport

Hello,
it would be very useful if you can modify the http.Client inside the Client struct.
For example for replacing http.Client.Transport to get your own response caching or rate limiting. Or changing timeouts.
I did not submit a PR because there are multiple ways to do it (exporting Client.http, adding a parameter to Init(), adding a new method(s) to Client...). But the change should be trivial.

Thank you.

[FEATURE] Image/Video helper func

Is your feature request related to a problem? Please describe.
Not a problem.

Describe the solution you'd like
Implement a image/video helper that returns the complete url.

Describe alternatives you've considered
None.

Additional context
None.

function GetMovieChanges yield's weird string after marshal

when GetMovieChanges or append_to_resonse used with changes as one of value the changes struct after marshal always has same weird string
image

On left I'm printing value before marshal and it's fine but after marshal result is weird string doesn't matter what movie I fetch

image
Different movie same string after marshal

[FEATURE] Improve code quality

Is your feature request related to a problem? Please describe.
I think that some variables names aren't good.

Describe the solution you'd like
Rename them. One letter is hard to reason about. Improve the code in general.

Describe alternatives you've considered
None for this issue.

Additional context
None.

Code refactor

Refactor comments, some structs names and break big functions into multiple lines.

Struggling to get ConfigurationCountries

Hey @cyruzin,
I am having problems getting the ConfigurationCountries by calling GetConfigurationCountries. It seems like the return type is *ConfigurationCountries which is a pointer to a []struct.
How can I iterate over that struct and extract the fields(Iso3166_1 and EnglishName)? It is also likely that this is obvious and I am just a bit dumb right know ๐Ÿ˜…

Would be great if you can give me an example.
Thanks
Tim ๐Ÿ˜Š

[FEATURE] Create benchmark tests

Is your feature request related to a problem? Please describe.
It's not a problem, it is just for checking how the lib is performing.

Describe the solution you'd like
Check the metrics and improve the speed.

Describe alternatives you've considered
Use jsoniter lib to encode/decode faster. Avoid allocations.

Additional context
https://github.com/json-iterator/go

[feature] remove embedded structure

Is your feature request related to a problem? Please describe.
Most (all?) results structure are embedded and not exportable, which made impossible to merge all results from many pages to one list

Describe the solution you'd like
Export 'results' structure

Describe alternatives you've considered
I've to create a list from the parent structure and do a double 'for' to iterate over all results

Additional context
For example

Results []struct {

[FEATURE] Provides a method to replace baseURL for external unit testing

Is your feature request related to a problem? Please describe.
other packages using the client cannot write a unit test because the baseURL variable cannot be modified and can only access the real tmdb address.

Describe the solution you'd like
add a method to modify baseURL

Describe alternatives you've considered

Additional context

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.