d03n3rfr1tz3 / hc-sr04 Goto Github PK

Normally functinon works fine, even with 10 ms "delay" but when we have big distance, or closed sensor by hand - proces slow down CPU cycle to about 150 ms

https://youtube.com/shorts/To0vZjwTudM

ESP32 S3 - 240 MHz

In C you should never return a dynamic array from a function. C has no garbage collector. So all those arrays you create, will never be deleted. In the loop function of your demo thousands of arrays are created, but never deleted.
If you need to return an array, use return parameters. This way the user is responsible to allocate and delete memory for the array.

Arduino Uno/ATmega328:
Measurement hangs unless pin 2 of 3 are used for the echo pin. Interrupts don't seem to be working on other pins.

Compiler says:

/somewhere/HC-SR04/src/HCSR04.h: In member function 'void HCSR04Sensor::begin(byte, byte*, byte)':
/somewhere/HC-SR04/src/HCSR04.h:27:143: warning: overflow in implicit constant conversion [-Woverflow]
   void begin(byte triggerPin, byte* echoPins, byte echoCount) { begin(triggerPin, echoPins, echoCount, 100000, eUltraSonicUnlock_t::unlockSkip); }

100000 is greater than INT_MAX for arduino.