dagjomar / leaflet.parallaxmarker Goto Github PK

Really neat Leaflet plugin! I saw your readme's "to do" note about

Make things work smoother on zoom animation

and it reminded me of how I ended up doing zoom animation for canvas elements here:
https://github.com/jwasilgeo/Leaflet.Canvas-Flowmap-Layer/blob/master/src/CanvasFlowmapLayer.js#L482

I know it isn't quite the same since it is for canvas elements, but maybe it'll give you some ideas to work with? It is a bit easier to follow in the original place I got the inspiration from here:
https://github.com/Leaflet/Leaflet.heat/blob/gh-pages/src/HeatLayer.js

Is the parallax effect developed only for the marker? Is there anything other object type? (such as polyline etc.)

If the marker moves by the parallax, the shadow and the popup remains in the original coordinates.

... as per Leaflet's guidelines to making plugins

Add some stuff in the README.md file about how the offset option works, and a code snippet creating a new marker. I don't want to read source code to make this work, I want to copy-paste stuff from the README.

Hey there! I'm using this plugin to simulate altitude on aircraft markers and it works quite nicely, until I delete a marker. It appears some of the event listeners don't get removed correctly. I tracked it down to line 22 in the .js file. The following line needs to be added to correctly handle zoom events after deleting an object:

this._map.off('zoomstart', this._onZoomStart, this);

Sorry that was all my fault and used the wrong branch