dailymotion-oss / jx-pipelines-visualizer Goto Github PK

Installed on Kubernetes v1.16.2

jx version
Version 2.1.149
Commit a5c2cb9
Build date 2020-09-21T11:50:59Z
Go version 1.13.8
Git tree state clean

Stack trace when I try to open logs for a pipeline run:

PANIC: runtime error: invalid memory address or nil pointer dereference goroutine 2172 [running]: github.com/urfave/negroni/v2.(*Recovery).ServeHTTP.func1(0x7fbc56c33a60, 0xc000b2e7f8, 0xc000ddcf00, 0xc000de0f50) /home/runner/work/jx-pipelines-visualizer/jx-pipelines-visualizer/vendor/github.com/urfave/negroni/v2/recovery.go:168 +0x166 panic(0x261f9a0, 0x409a390) /opt/hostedtoolcache/go/1.15.2/x64/src/runtime/panic.go:969 +0x175 github.com/jenkins-x/jx/v2/pkg/cloud/buckets.ReadHTTPURL(0xc00068e420, 0xa1, 0x0, 0x6fc23ac00, 0x0, 0x1e00, 0xc000dd5da0, 0x10) /home/runner/work/jx-pipelines-visualizer/jx-pipelines-visualizer/vendor/github.com/jenkins-x/jx/v2/pkg/cloud/buckets/buckets.go:79 +0xfa github.com/jenkins-x/jx/v2/pkg/cloud/buckets.ReadURL(0xc00068e420, 0xa1, 0x6fc23ac00, 0x0, 0x0, 0x0, 0x0, 0x0) /home/runner/work/jx-pipelines-visualizer/jx-pipelines-visualizer/vendor/github.com/jenkins-x/jx/v2/pkg/cloud/buckets/buckets.go:65 +0xb4 github.com/dailymotion/jx-pipelines-visualizer/web/handlers.(*LogsHandler).ServeHTTP(0xc000dcb8e0, 0x7fbc56c33a60, 0xc000b2e7f8, 0xc000ddd100) /home/runner/work/jx-pipelines-visualizer/jx-pipelines-visualizer/web/handlers/logs.go:58 +0x398 github.com/gorilla/mux.(*Router).ServeHTTP(0xc000d15ec0, 0x7fbc56c33a60, 0xc000b2e7f8, 0xc000ddcf00) /home/runner/work/jx-pipelines-visualizer/jx-pipelines-visualizer/vendor/github.com/gorilla/mux/mux.go:210 +0xd3 github.com/urfave/negroni/v2.Wrap.func1(0x7fbc56c33a60, 0xc000b2e7f8, 0xc000ddcf00, 0xc000dcbf60) /home/runner/work/jx-pipelines-visualizer/jx-pipelines-visualizer/vendor/github.com/urfave/negroni/v2/negroni.go:55 +0x4d github.com/urfave/negroni/v2.HandlerFunc.ServeHTTP(0xc000dcbf20, 0x7fbc56c33a60, 0xc000b2e7f8, 0xc000ddcf00, 0xc000dcbf60) /home/runner/work/jx-pipelines-visualizer/jx-pipelines-visualizer/vendor/github.com/urfave/negroni/v2/negroni.go:29 +0x4e github.com/urfave/negroni/v2.middleware.ServeHTTP(...) /home/runner/work/jx-pipelines-visualizer/jx-pipelines-visualizer/vendor/github.com/urfave/negroni/v2/negroni.go:47 github.com/urfave/negroni/v2.(*Static).ServeHTTP(0xc000dfc450, 0x7fbc56c33a60, 0xc000b2e7f8, 0xc000ddcf00, 0xc000dcbf80) /home/runner/work/jx-pipelines-visualizer/jx-pipelines-visualizer/vendor/github.com/urfave/negroni/v2/static.go:41 +0xf9 github.com/urfave/negroni/v2.middleware.ServeHTTP(...) /home/runner/work/jx-pipelines-visualizer/jx-pipelines-visualizer/vendor/github.com/urfave/negroni/v2/negroni.go:47 github.com/urfave/negroni/v2.(*Recovery).ServeHTTP(0xc000de0f50, 0x7fbc56c33a60, 0xc000b2e7f8, 0xc000ddcf00, 0xc000dcbfa0) /home/runner/work/jx-pipelines-visualizer/jx-pipelines-visualizer/vendor/github.com/urfave/negroni/v2/recovery.go:210 +0x8c github.com/urfave/negroni/v2.middleware.ServeHTTP(...) /home/runner/work/jx-pipelines-visualizer/jx-pipelines-visualizer/vendor/github.com/urfave/negroni/v2/negroni.go:47 github.com/urfave/negroni/v2.(*Negroni).ServeHTTP(0xc000dfc4b0, 0x2e10560, 0xc000afe0e0, 0xc000ddcf00) /home/runner/work/jx-pipelines-visualizer/jx-pipelines-visualizer/vendor/github.com/urfave/negroni/v2/negroni.go:107 +0xfb net/http.(*ServeMux).ServeHTTP(0x40cb7a0, 0x2e10560, 0xc000afe0e0, 0xc000ddcf00) /opt/hostedtoolcache/go/1.15.2/x64/src/net/http/server.go:2417 +0x1ad net/http.serverHandler.ServeHTTP(0xc000dea0e0, 0x2e10560, 0xc000afe0e0, 0xc000ddcf00) /opt/hostedtoolcache/go/1.15.2/x64/src/net/http/server.go:2843 +0xa3 net/http.(*conn).serve(0xc000df6780, 0x2e18820, 0xc000db3c00) /opt/hostedtoolcache/go/1.15.2/x64/src/net/http/server.go:1925 +0x8ad created by net/http.(*Server).Serve /opt/hostedtoolcache/go/1.15.2/x64/src/net/http/server.go:2969 +0x36c

Currently, the container image will run as root.

I don't think that anything that this does requires root so it'd be good to drop to an unprivileged user so folks who use restrictive PodSecurityPolicies can still use this.

When executing the second command of the README, I've got an error:

➜ helm install jx-pipelines-visualizer/jx-pipelines-visualizer \
 --name jx-pipelines-visualizer \
 --namespace jx
Error: unknown flag: --name

I had to use this command instead to install the visualizer:

➜ helm install jx-pipelines-visualizer/jx-pipelines-visualizer \
 --generate-name=true \
 --namespace jx

Not sure what's wrong, here is the helm version I'm using:

helm version
version.BuildInfo{Version:"v3.3.1", GitCommit:"249e5215cde0c3fa72e27eb7a30e8d55c9696144", GitTreeState:"dirty", GoVersion:"go1.15"}

it was mentioned on the last office hours that folks might add the ability to visualise the steps of pipelines.

I thought I’d mention this OSS CSS / icon and JS library that octant uses - clarity - it as a kind of pipeline visualisation widget
https://clarity.design/documentation/timeline

which might be handy for rendering the pipeline steps?