dajuric / simple-http Goto Github PK

I'm using simple-http to serve a few static files from within a game. Everything is working great, so thanks!
I was wondering if there is any type of clean-up that I need to do when shutting down the server? I couldn't find anything about that in the samples or in your code-project article.

Hey,
I've noticed that the Method collection is a simple list which is NOT thread safe. Using it in a multithreaded application (==Task.Run) can result in weird behaviour which could potentially destroy the process.
I suggest moving to a collection from System.Collections.Concurrent or using an access lock object and locking it with "lock(object){}". You should pay attention to deadlocks.

Another thing which i noticed is that the Route class is static which isnt optimal. There are 2 reasons which came to my mind:

1. Testability. You will have a hard time Unit Testing your application.
2. Multiple server instances with different behaviours are not possible with the current approach.

I hope you find those suggestion helpful

"application/x-www-form-urlencoded;charset=UTF-8" is not treated as post request, simple-http cannot get values.

in RequestExtensions.Form.cs, we only treat ContentType == "application/x-www-form-urlencoded" as a valid post request, maybe we can use IndexOf method to decide?

static bool ParseForm(HttpListenerRequest request, Dictionary<string, string> args)
        {
            if (request.ContentType != "application/x-www-form-urlencoded")
                return false;