dalibor / cyrillizer Goto Github PK

Error translating combination "ля" in word "для". Now: "dlя", expected: "dlya"

Я я Ч ч Щ щ Ш ш ь Ь ъ Ъ Ю ю are missing

The gem throws stack level too deep error from time to time.

ActionView::Template::Error (stack level too deep):
cyrillizer (0.1.0) lib/cyrillizer/converter.rb:27

I am using it here:
class String
def parameterize_string
self.to_lat.parameterize
end
end

I think you should sort the hash over the length:

 def to_cyr
      a=alphabet.invert.sort_by{ |k,v| k.length }.reverse.to_h
      code(self.dup,a)
 end

Currently it happens that for instance nj get translaterated as нј instead of њ becausej comes before it in the alphabet hash and it gets replaced by the same looking but different character, such as this:

from = "j"
 bytes = Array (1 element)
  [0] = 106
to = "ј"
 bytes = Array (2 elements)
  [0] = 209
  [1] = 152

after which gsub('nj'..) doesn't produce anything.

Sorting the array differently gets rid of this problem.

When someone does not want to use YAML alphabet provided by the gem. Or, when someone wants to use their own alphabet for conversion.

"J".to_cyr have to be "Дж"
but now it is "J"