damianreeves / commander.fody Goto Github PK

... Pretty much just as it says. I've got a project using Commander which I'm trying to move to a new system, and therefore it's going looking for all the packages it needs, and Commander just throws errors whether I ask PM directly for it or I do it via the Package Manager interface.

Wha' happened?

Would it be possible to get a pull request to here https://github.com/Fody/FodyAddinSamples that demonstrates the use of this addin?

This is a basic requirement which slipped through the cracks (working on this fix in the dev branch).

As per Issue #4 this does not work in Windows Phone.
A fix is now available for WinRT, I'm still having issues with Windows Phone testing.

Version 0.0.2.0 NuGet package doesn't support Portable Libraries.

It fails to load with the following errors:

The primary reference "Commander.Fody" could not be resolved because it has an indirect dependency on the framework assembly "mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089" which could not be resolved in the currently targeted framework. ".NETPortable,Version=v4.0,Profile=Profile104". To resolve this problem, either remove the reference "Commander.Fody" or retarget your application to a framework version which contains "mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089".

The primary reference "Commander.Fody" could not be resolved because it has an indirect dependency on the framework assembly "System.Xml.Linq, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089" which could not be resolved in the currently targeted framework. ".NETPortable,Version=v4.0,Profile=Profile104". To resolve this problem, either remove the reference "Commander.Fody" or retarget your application to a framework version which contains "System.Xml.Linq, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089".

The primary reference "Commander.Fody" could not be resolved because it has an indirect dependency on the framework assembly "System.Core, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089" which could not be resolved in the currently targeted framework. ".NETPortable,Version=v4.0,Profile=Profile104". To resolve this problem, either remove the reference "Commander.Fody" or retarget your application to a framework version which contains "System.Core, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089".

After the constructor for my ViewModel is called, I am noticing that in Debug builds, the Command that I have an attribute on is initialized and works correctly. However in a Release build, the Command is null and does nothing.

Fody Version 2 is out and you will need to do an update for your addin to be usable with it

Specifically:

• Update to the newest Fody.Cecil nuget
• Change the min dependency ranged for Fody to be at least 2.0

Please ping me if u need help

I'm receiving this error when trying to use Commander inside a PCL project.

Error   1   Fody/Commander: Could not resolve PresentationCore. Please ensure you are using .net 3.5 or higher.
Inner message:Can not find 'PresentationCore, Culture=neutral, PublicKeyToken=null'.
Tried:
C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\.NETPortable\v4.0\Profile\Profile104\mscorlib.dll
C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\.NETPortable\v4.0\Profile\Profile104\mscorlib.dll
C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\.NETPortable\v4.0\Profile\Profile104\System.Core.dll
C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\.NETPortable\v4.0\Profile\Profile104\System.dll
C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\.NETPortable\v4.0\Profile\Profile104\System.Net.dll
C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\.NETPortable\v4.0\Profile\Profile104\System.Runtime.Serialization.dll
C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\.NETPortable\v4.0\Profile\Profile104\System.ServiceModel.dll
C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\.NETPortable\v4.0\Profile\Profile104\System.ServiceModel.Web.dll
C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\.NETPortable\v4.0\Profile\Profile104\System.Windows.dll
C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\.NETPortable\v4.0\Profile\Profile104\System.Xml.dll
C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\.NETPortable\v4.0\Profile\Profile104\System.Xml.Linq.dll
C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\.NETPortable\v4.0\Profile\Profile104\System.Xml.Serialization.dll
Z:\Documents\workspace\NPlus1DaysOfMvvmCross\N-10-KittensDb\packages\MvvmCross.HotTuna.CrossCore.3.0.5\lib\portable-win+net45+MonoAndroid16+MonoTouch40+sl40+wp71\Cirrious.CrossCore.dll
Z:\Documents\workspace\NPlus1DaysOfMvvmCross\N-10-KittensDb\packages\MvvmCross.HotTuna.CrossCore.3.0.5\lib\portable-win+net45+MonoAndroid16+MonoTouch40+sl40+wp71\Cirrious.MvvmCross.Localization.dll
Z:\Documents\workspace\NPlus1DaysOfMvvmCross\N-10-KittensDb\packages\MvvmCross.HotTuna.Plugin.Sqlite.3.0.5\lib\portable-win+net45+MonoAndroid16+MonoTouch40+sl40+wp71\Cirrious.MvvmCross.Plugins.Sqlite.dll
Z:\Documents\workspace\NPlus1DaysOfMvvmCross\N-10-KittensDb\packages\MvvmCross.HotTuna.StarterPack.3.0.5\lib\portable-win+net45+MonoAndroid16+MonoTouch40+sl40+wp71\Cirrious.MvvmCross.dll
Z:\Documents\workspace\NPlus1DaysOfMvvmCross\N-10-KittensDb\packages\PropertyChanged.Fody.1.38.1.0\Lib\portable-net4+sl4+wp7+win8+MonoAndroid16+MonoTouch40\PropertyChanged.dll. AssemblyResolver is: InnerWeaver   KittensDb.Core

I'm guessing the API can be made even more concise eg. can the string argument be optional, and derived from the method name? eg

[CanExecute]
public bool CanGotoTwoPage() {
...
}

[OnCommand]
public void GotoTwoPage() {
...
}

Hi, upon binding commands with MVVMCross, there is a Warning below, could you please have a look?

MvxBind:Error: 0.94 Problem seen during binding execution for binding Click for SubmitCommand - problem TargetInvocationException: Exception has been thrown by the target of an invocation.
at System.Reflection.MonoMethod.Invoke (System.Object obj, BindingFlags invokeAttr, System.Reflection.Binder binder, System.Object[] parameters, System.Globalization.CultureInfo culture) [0x00050] in /Users/builder/data/lanes/2970/46c3f7e0/source/mono/mcs/class/corlib/System.Reflection/MonoMethod.cs:303
at System.Reflection.MethodBase.Invoke (System.Object obj, System.Object[] parameters) [0x00000] in /Users/builder/data/lanes/2970/46c3f7e0/source/mono/external/referencesource/mscorlib/system/reflection/methodbase.cs:277
at MvvmCross.Platform.WeakSubscription.MvxWeakEventSubscription`2[TSource,TEventArgs].AddEventHandler () [0x0002c] in V:\Xamarin\MvvmCross\MvvmCross\Platform\Platform\WeakSubscription\MvxWeakEventSubscription.cs:118

InnerException was InvalidProgramException: Missing or incorrect header for method add_CanExecuteChanged
at (wrapper managed-to-native) System.Reflection.MonoMethod:InternalInvoke (System.Reflection.MonoMethod,object,object[],System.Exception&)
at System.Reflection.MonoMethod.Invoke (System.Object obj, BindingFlags invokeAttr, System.Reflection.Binder binder, System.Object[] parameters, System.Globalization.CultureInfo culture) [0x00038] in /Users/builder/data/lanes/2970/46c3f7e0/source/mono/mcs/class/corlib/System.Reflection/MonoMethod.cs:295

We need to add support for using a library implementation of ICommand

• Need a CommandImplementationAttribute
• Need to use CommandImplementationAttribute for detecting which ICommand to use

I am getting "The project targets .NETCore while the file reference targets .NET Framework"

Could you make it work with WinRT and Windows Phone projects?