damoon / d8s Goto Github PK

add environment variable to detect d8s usage from tilt and disable docker prune schedule
https://docs.tilt.dev/api.html#api.docker_prune_settings

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

Rate-Limited

These updates are currently rate-limited. Click on a checkbox below to force their creation now.

• Update golangci/golangci-lint-action digest to 3a91952
• Update yokawasa/action-setup-kube-tools action to v0.11.1
• Update actions/checkout action to v4
• Update actions/setup-go action to v5
• Update docker Docker tag to v26
• Update golangci/golangci-lint-action action to v6
• Update goreleaser/goreleaser-action action to v5
• 🔐 Create all rate-limited PRs at once 🔐

Open

These updates have all been created already. Click a checkbox below to force a retry/rebase of any.

• Update actions/checkout digest to f43a0e5
• Update actions/setup-go digest to 93397be
• Update docker:24.0.2-dind Docker digest to 1d148de
• Update ghcr.io/turbine-kreuzberg/dind-nurse:latest Docker digest to 7232d44
• Update dependency tilt-dev/tilt to v0.33.13
• Update docker Docker tag to v24.0.9
• Update dependency golang/go to v1.22.3
• Update dependency golangci/golangci-lint to v1.58.1
• Update helm/kind-action action to v1.10.0
• Update module github.com/urfave/cli/v2 to v2.27.2
• Click on this checkbox to rebase all open PRs at once

Detected dependencies

• Check this box to trigger a request for Renovate to run again on this repository

How to reproduce:

# list port-forwards before
ps u | grep 'kubectl port-forward'

# run some minimal d8s commands
d8s up sh -c 'exit 0'
d8s run sh -c 'exit 0'

# list port-forwards after
ps u | grep 'kubectl port-forward'

Expected behaviour: The number of port-forwards stays the same.

Actual behaviour: The number of port-forwards increases every time d8s is executed.

d8s version: 0.9.2

uname -a: Linux [REDACTED] 5.4.0-97-generic #110~18.04.1-Ubuntu SMP Mon Jan 17 20:50:31 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

running something like this in a Tiltfile will fail when running d8s up tilt up:

def helmfile_docker(cmd):
  pwd = local("pwd | tr -d '\n' ")
  return local("docker run --rm -w /workdir -v %s:/workdir --entrypoint=bash quay.io/roboll/helmfile:v0.143.0 -c '%s'" % (pwd, cmd) )

a possible solution to that is using unset in the local directive like that:

def helmfile_docker(cmd):
  pwd = local("pwd | tr -d '\n' ")
  return local("unset DOCKER_HOST; docker run --rm -w /workdir -v %s:/workdir --entrypoint=bash quay.io/roboll/helmfile:v0.143.0 -c '%s'" % (pwd, cmd) )

This behaviour is not obvious although understandable as d8s overwrites the DOCKER_HOST.
This should maybe be mentioned in the documentation or handled in some other way?