damselem / newsletter Goto Github PK

I think that the 'Fork me' badge should open Github in a new tab.

When you access /users/:id and the list of posts is displayed, only non-archived posts should be displayed.

Right now when a user submits a post and finds out that he has a typo or some other mistake, he has to delete the post, fix the mistake and resend the whole post.

Since this is a common usecase we would like to have an 'edit' button next to the 'delete' button, that would allow you to edit your posts.

While trying to take a look at the project I found myself encountering multiple issues/questions:

• Rails version in Gemfile is different than the Gemfile.lock version.
• Which version of ruby should I use?
• Probably need a database.yml with development defaults in it. (sqlite will be the easiest)
• How do I go past the OAuth phase when running locally?
• How do I run tests/ which tests to run?

Anyway, I really think adding more details to the wiki would make it much easier for people to contribute.

Might be worth using this gem to handle the incoming mail.

https://github.com/honeybadger-io/incoming

The rake task is executed daily by Heroku, and whenever is executed it checks if it's Thursday or not. If it's Thursday, it will collect all the posts (using Post.from_current_week) from previous Sunday to the time of the execution. That means that all posts send after Thursday (when the rake task is executed to deliver the newsletter) and Sunday, will be skipped.

Use the gravatar icon in the right side of the header to place a "User" menu.

In that menu, add a logout button.

When you receive the weekly newsletter, the Klarna logo is not show until some seconds after due to Heroku's idling.

To avoid this issue, we should place at least the logo asset in a CDN or somewhere else.

Tomer recommends adding to the end of the newsletter emails and explanation of how to send your posts. Either a sentence or a link to the newsletter app, with a short example (email address, formatting, etc).

In the long term we would like to be able to search for posts that were published to the app by title or content.

The email digest format contains the posts subject and the full body.
This results in a very long email.
I think it is better to include on the first line/x words of the post body.
Original:

Gemfile dependency graph _by Daniel Salmeron Amselem_
Although you could use the Gemfile.lock to track dependencies between different gems, there's also a more graphical and nice way to see such information.
brew install graphviz && gem install ruby-graphviz && bundle viz
Take a look at the Bundler documentation for more information about the bundle viz command.

Suggestion:

Gemfile dependency graph _by Daniel Salmeron Amselem_
Although you could use the Gemfile.lock to track dependencies between different gems...

Any thoughts? suggestions?

Write proper documentation for the Newsletter.

This will allow easy searching/filtering, and maybe useful to focus on things that I am interested in.

If someone that receives the newsletter has an out-of-office reply enabled, then their auto-reply will be interpreted as a new post. Here's an example.

We should ignore these types of messages. They can easily be ignored by checking if the email has the X-Autoreply header set to 'yes'.