Leptonica 1.83.0 breaks tesseract, which in turn breaks pdfsandwich about leptonica HOT 10 CLOSED

I believe the problem is in pdfio2.c, lines 569-570.

        if (!cid)
            return ERROR_INT("cid not made from file", __func__, 1);

Please remove those two tlines and see if the test succeeds.

from leptonica.

Removing these lines allows processing of similar files without error, so the patch should be good.

Many thanks for quick response.

from leptonica.

Excellent. The fix is now in.

from leptonica.

Will there be a point release including the patch? If not, I'll suggest adding the patch to the gentoo package, so that 1.83.0 will be working there, too.

from leptonica.

@stweil

It's a bit of work to make a patch release. I'll follow the advice of the tesseract maintainers, which is why I left this issue open for now.

from leptonica.

Are you referring to a patch release 1.83.1? As the latest code is already prepared for 1.84.0, a patch release would need a branch 1.83 (I can add that if you want) and a list of patches which should be added.

Which commits after 1.83.0 should be included in the patch release, too? I'd suggest these commits:

• a7bf5cc
• 544561a

Are there others?

from leptonica.

That's a nice offer, Stefan.

I can also do it without a branch, modifying 1.84.0 --> 1.83.1 and including all existing commits.
Then wait a few days before changing 1.83.1 --> 1.84.0.

from leptonica.

But on second thought, it might be easier for you. Those two commits are the only important ones.

from leptonica.

See pull request #660 which adds the required changes for 1.83.1 to the new branch 1.83.

from leptonica.

Much thanks, Stefan. Except for a patch on 1.81, this is the only patch that has been required for 5 years, since 1.75.

Closing this issue.

from leptonica.