daniel-frak / dummy4j Goto Github PK

• add ResolvedValue::toString
• log when path could not be resolved by DefaultExpressionResolver

dummy.book.title() returns "The Return of of Fandango"

A demo project presenting:

1. Functionality (basic usage)
2. Modules (selected, with configurable builders)
3. Expression resolver (advanced usage)
4. Commerce usage example

Will be glad to hear your opinion about this

Using the default time zone in tests may break them on different environments.

While in this instance, no errors have presented themselves yet, using a defined timezone will result in cleaner, more stable code.

We should allow all builders to be reusable by 'undoing' any methods called on them. In this case I mean that everywhere we have a withoutX, like in CreditCardNumberBuilder and CreditCardBuilder (withoutFormatting), we should also have a withFormatting method.

Currently, unit tests for dummies only check if the returned values are not null. Moreover, the ScifiDummy::spaceship method resolves an incorrect key.

Example application: efficient-mvp-example

After building application with the following command:

mvn clean package && java -jar -Dspring.profiles.active=dev,init target/efficient-mvp-example-0.0.1-SNAPSHOT.jar 

and making the http://localhost:8080/api/init?seed=1&how-many-books=100 request I'm getting MissingLocaleException.

The logs show:
Loading definitions from: [BOOT-INF/classes/dummy4j/en/book.yml]
instead of
Loading definitions from: [dummy4j/en/book.yml, …]

Adding another condition specifically for Spring Boot projects in YamlFileLoader::isInAllowedPath seems to fix the problem, but there must be a better way that doesn't require hardcoding:

    private boolean isInAllowedPath(String resource, List<String> paths) {
        boolean isInAllowedPath = false;
        for (String path : paths) {
            if (resource.startsWith(path) || resource.startsWith("BOOT-INF/classes/" + path)) {
                isInAllowedPath = true;
                break;
            }
        }

        return isInAllowedPath;
    }

Useful links:
Resource pattern filter for complete resource path #148