daniel-tran / meaningless Goto Github PK

Download of Psalm 119 was limited to 100 verses. Issue resolved when max_value of common.py / get_capped_integer increased from 100 to 176 in function get_capped_integer(number, min_value=1, max_value=176). Incidentally, I think get_end_of_chapter() can also be changed to return 176 since that is the maximum number of verses in any chapter of Bible i.e. Psalm 119

I'm rather new to Python and, though I figured out most of the rest your app, I cannot find a way to change the translation. It always prints NIV. Am I able to pass it as a string for my simple python script?

It would be helpful to be able to generate from the library a list/dictionary of the supported translations, ideally both their full name and their 'code'. That way you could, for example, easily generate a drop-down list of translations (and it would automatically update if another translation is supported).

Summary of the problem

i was trying to extract / download the book of Psalms. noticed the extractor / downloader on chapter 119 is stopped on verse 100. trying to manually set passage_range, e.g extractor.get_passage_range(book="NASB1995", chapter_from=119, chapter_to=119, passage_from=101, passage_to=176) returns the chapter 119, verse 100.

Expected Behaviour

should extract / download the required passage after 100.

Steps to replicate the problem

• create a new python project
• install the meaningless python package.
• add from meaningless import WebExtractor.
• set up extractor
• print the extractor result.

from meaningless import WebExtractor

extract = WebExtractor(translation="NASB1995")
passage = extract.get_passage_range(book="Psalms", chapter_from=119, chapter_to=119, passage_from=101, passage_to=176)
print(passage)

# above code prints:
# ¹⁰⁰ I understand more than the aged,
# Because I have observed Your precepts.

Environment

• Python version: 3.10.12
• Operating system: Linux (Ubuntu 22.04.3 LTS)
• Library version: 1.0.0