Giter VIP home page Giter VIP logo

prj-rev-bwfs-dasmoto's People

Contributors

danielehuang avatar

Watchers

James Cloos avatar

prj-rev-bwfs-dasmoto's Issues

Code Structure

The code base for this project is well structured and organized!
Your utilization of indentations and whitespace made for a legible code structure that was easy to navigate through and review. You will definitely want to make a habit of this and continue to implement this concept throughout your future projects. Great job on this!

Comments

I know the code base for this project wasn't necessarily large so adding comments wouldn't be a priority but do try to make a habit out of it.
Comments are helpful in keeping your code structure legible and further organized which can not only help yourself, but those reading your code as well. You can use comments to section of parts of your code for efficient searching or declare your intentions with why/how you chose to implement a feature so it gives the reader an idea with how to approach your code. Try it for future projects!

Spec

This Dasmoto project looks great as it’s identical and accurate to the design spec. This means you were able to apply all the necessary styling attributes to the necessary elements, awesome job!

The only area I'd like to bring to your attention is that "price" is not a valid tag in HTML. What you can do in its place is use a "span" tag and give it a class of "price" to style the desired portion.

Other than that, it looks great!

Summary

Great job on this first project! Your Dasmoto project looks great on both the code side and the web side!

  • Utilization of indentations and whitespace.
  • Addition of comments for future projects.
  • Relative paths over absolute paths.
  • Usage of "span" tag in place of "price" tag.
  • Accurate to design spec.

Overall, amazing work! Keep it up!
Grade: Meets expectation.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.