danieljfarrell / fvm Goto Github PK

Hi Daniel.

I have developed a framework where one of the validation scripts is based on your FVM notes.
I would like to open source our framework for other researchers to use under BSD 3 license.
In the process of cleaning code, references etc, I noticed that your FVM project does not have any license, which may be a problem to open source it from my side.
If you do not mind me asking: could it be possible to add a license to your github?

That would help the development of other projects based on your very useful script.

Thanks a lot.
Regards

Hello. I was looking at your really excellent notes on discretizing finite volume problems. However for some reason, it seems like something is amiss with either mathjax or katex or whatever is formatting the latex equations. Here is a picture of what I am seeing in my browser. I actually tried 2 different browsers to see if it was a problem on my end, but it was not.

Not sure what it could be, but perhaps it is some simple adjustment to the version or something when generating the static pages.

Here is a picture of what I am seeing.

Hi Daniel,
I went through the code and I see there may be rooms for efficiency. By the way I have some questions:

1. Why the the model iteself creates a, d, k while you have created them already in the example code?
2. Is there any reason the solver is not implemented inside Model calss?
3. Why not to include the source term?