danielnelson / tgconfig Goto Github PK

I was taking a look at this POC because we are interested in being able to configure dynamically Telegraf.

Do you have some doc with the general ideas used in this code?

I don't follow the reasoning behind the Wait() for the toml-http loader.
I guess the idea is to ask for the config and then call /config/poll to wait until the server has something new, avoiding callings that will retrieve the same exact config.

This polling could be different for each server, so, Telegraf should send its hostname at least, right (for /config and for /config/poll)?

Then, the server answering should keep a registry of the last time each server ask for its config and a bit to know if something has changed since then, to finish a polling from that server. Something like this?

Curently in the code /config/poll is executed before calling /config.
Looks strange, because if Telegraf is restarted, the config server will keep the polling call indefinitely, not getting the config (if my logic for the server is right, of course).

Thanks for the POC!