Wrong number of branch points with OpenCover about reportgenerator HOT 11 CLOSED

Your XML contains this information about branches:

<BranchPoints>
  <BranchPoint vc="2" uspid="108875" ordinal="0" offset="56" sl="23" path="0" offsetend="58" fileid="3073" />
  <BranchPoint vc="2" uspid="108876" ordinal="1" offset="56" sl="23" path="1" offsetend="69" fileid="3073" />
</BranchPoints>

This seems to be correct. And then the HTML report will show 2 of 2 branches covered.
I created a similar class and I get 2 branches with both are shown as covered in the report.

Do you pass a single coverage report to ReportGenerator or several files?

from reportgenerator.

Thanks for your amazingly fast response.

I have a batch file which executes the coverage, which just uses one results.xml. The line of code which executes the Report Generator is this;

..\packages\ReportGenerator.2.1.3.0\reportgenerator.exe -reports:results.xml -targetdir:CoverageReport

I do execute three unit test projects through OpenCover (which calls mstest with three testcontainer arguments). To be sure, I've checked the file id's, but there's only one file with id '3073' as in the example.

from reportgenerator.

Could you provide the full results.xml?

from reportgenerator.

I took a look at the results.xml you have sent me.
I think I found the reason why you get strange results.

Each of your unit test assemblies use a separate copy of the X.BusinessLayer.dll.
The X.BusinessLayer.dll is referenced 4 times. One test assembly covers the two branches the others don't cover the relevant code.
ReportGenerator groups the assemblies by their name and then shows 2 of 8 branches as covered.

To fix this issue try using the following option when executing OpenCover: -mergebyhash

https://github.com/OpenCover/opencover/wiki/Usage#optional-arguments

Please let me know if this helps.

from reportgenerator.

Yes, this helps. My issue is resolved. Thanks a lot for your outstanding support!

from reportgenerator.

@danielpalme, I think I have a similar problem, but OpenCover's -mergebyhash isn't working for me.
The OpenCover XML is reporting significantly different numbers than I'm getting from ReportGenerator.

I'd be happy to send along my files for troubleshooting.

from reportgenerator.

Please send me your OpenCover file.
And (if possible) a class file, where you think something is wrong.

from reportgenerator.

@danielpalme, I'll be sending you my file soon.
Specifically, I'm not sure if my branch point data is inaccurate, but ReportGenerator says I have 1897 classes and 56.7% branch coverage, while my OpenCover output says I have 2443 classes (1549 visited) and 60.63% branch coverage.

from reportgenerator.

@danielpalme, just realized I should tell you I emailed my file to you, in case it gets caught in your spam filters 😄

from reportgenerator.

I received your files. I will look into them within the next days.

This wiki page explains some metrics of ReportGenerator: https://github.com/danielpalme/ReportGenerator/wiki/Calculation-details

from reportgenerator.

Thanks, I appreciate the help!

from reportgenerator.