Giter VIP home page Giter VIP logo

Comments (4)

danijar avatar danijar commented on July 17, 2024

Hi @xlnwel, thanks for your questions. Could you please move your question about the RSSM into a second Github issue? That way, it'll be easier for others who might have similar questions.

Regarding the action distribution, the reason the mean is bounded to [-5, +5] before being transformed by the tanh is to avoid numerical instabilities. For computing log-probabilities, we need to invert the tanh and this becomes difficult in highly saturated regions. By the way, SAC also bounds the mean using tanh but doesn't scale up by 5 afterwards, which limits its action range a bit too much. Check out the link in the code to play around with the tanh normal distribution: https://www.desmos.com/calculator/rcmcf5jwe7

I'm closing the issue for now, but please follow up if this doesn't answer your question.

from dreamer.

yusukeurakami avatar yusukeurakami commented on July 17, 2024

Sorry if I am not understanding your former answer correctly, but why we need SampleDist? I especially don't understand what argmax in SampleDist.mode() is doing.

tf.gather(sample, tf.argmax(logprob))[0]

from dreamer.

xlnwel avatar xlnwel commented on July 17, 2024

Many tfd.distributions methods such as entropy become invalid after tfd.TransformedDistribution and SampleDist can be used to approximate those stats. The line you cited just found the sample with the maximum logprob.

from dreamer.

yusukeurakami avatar yusukeurakami commented on July 17, 2024

@xlnwel Thank you! I see.

from dreamer.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.