dankoy / korvo-to-anki Goto Github PK

Is your feature request related to a problem? Please describe.
User can run export multiple time with the same database, but if the first export was successful, then it should save state. Then on next runs export won't do anything, except user doen't add new word to database.

Describe the solution you'd like
Possible solution write state as a txt file in the same directory as jar. The contents are words in new line. The next boot of application will know about state of previous runs and filter out already exported words.

Describe alternatives you've considered
None

Additional context
None

Describe the bug
When state is saved it takes all data from db and rewrites it in file.

To Reproduce

1. Take one db.
2. Make export
3. take another db with different words
4. Make export
5. State contains data only from second db.

Expected behavior
Take current state and add to it newly exported words. Don't overwrite everything from database, because databases could be different.

Desktop (please complete the following information):

• MacOS 13.6
• Hardware: Apple M1 Pro
• SDK: JDK-17.0.8.1-tem

Describe the bug
In TemplateCreatorService create method finished faster than executor service shuts down.

To Reproduce

1. Run export with thousands of words.
2. Export could be not full because latch didn't wait for all runnable tasks.

Expected behavior
Export method waits for all runnable tasks to finish.

Desktop (please complete the following information):

• OS: Mac
• SDK: [e.g. jdk-17.0.1]

Is your feature request related to a problem? Please describe.
Could work better with async extractor service in full async mode.

Describe the solution you'd like
If extractor service works in async mode, then requests to external API could also be done using async methods.

For help see:
https://koreader.rocks/doc/modules/ui.translator.html

https://github.com/koreader/koreader/blob/34ba2fab301f43533ee6876d78809f685dd05614/frontend/ui/translator.lua

https://github.com/ssut/py-googletrans/blob/master/googletrans/client.py

Is your feature request related to a problem? Please describe.
When user used "auto" as sourceLanguage key in command "anki-exporter", application skip dictionaryapi. It would be better to detect automatically which language is used before make decision to use dictionaryapi or not.

Describe the solution you'd like
Use Tika language detection to check whole vocabulary-builder database. Seems like it's correct to take one word in book as example word and detect language for whole book. As long as whole book read in one language is should be enough.

Describe alternatives you've considered
None

Additional context
None

Describe the bug
Can't create export file with colons on windows.

To Reproduce
Run app on windows OS.

Expected behavior
Export file should be created without errors. Probably should change colons to something else.

Desktop (please complete the following information):

• OS: Windows 10
• SDK: jdk-17.0.2

Additional context
Caused by: java.nio.file.InvalidPathException: Illegal char <:> at index 76:

Is your feature request related to a problem? Please describe.
In shell command, user can choose if he wants to have definitions and/or examples of words. Or he wants just translation.
This can help to speed up process of conversion for users who don't want lookup definitions in external API.

Describe the solution you'd like
Possible solution in command to have additional keys that can turn on or off functionality.
For example: convert --text text --useGoogleTranslate true --useDictionaryApi true --options t,mt,rm
Default for --useGoogleTranslate --useDictionaryApi is false.
Application will just go in google translate for translations and don't care about transcriptions, definitions, examples, synonyms, antonyms.

For help see:
https://koreader.rocks/doc/modules/ui.translator.html

https://github.com/koreader/koreader/blob/34ba2fab301f43533ee6876d78809f685dd05614/frontend/ui/translator.lua

https://github.com/ssut/py-googletrans/blob/master/googletrans/client.py

https://api.dictionaryapi.dev/api/v2/entries/en/

Probably valid only for english as a source language

It should be used branch strategy with dev environment.

All changes are made in dev branch. Then when release has to be done, then open PR to main branch from dev. Also increase project version.

Also dependabot should make pull requests to dev branch. Not dependencies. So the action to rebase main to dependencies is no longer necessary.