add tslint to the project.

Need to show ETH and other balances.

I've done as described. Parity is running with account unlocked.

I get

After running npm install, I try: npm run auto-start-ganache, but I get the error message:

'ETH_ENV' is not recognized as an internal or external command,
operable program or batch file.

This is running on Windows 10, powershell console window, npm v5.7.1

User account balance should automatically update as it changes. My account just received 5 ETH but the balance shown below did not reflect it until I refreshed the browser page.

as per the discussion at: daostack/arc.js#169

Subscriptions are working in the client repository (and there is a test for it)

There must be a subtle difference between the definitiosn of the docekr containers or the test setup that explains why subscrptions fail.

Adding unit tests could help, especially for redux-thunk actions.

This info is currently missing from the subgraph, tracked in this issue: daostack/subgraph#43

Use this to validate
https://web3js.readthedocs.io/en/1.0/web3-utils.html?highlight=isAddress#isaddress

the old version sof the packages have been removed: https://www.npmjs.com/package/flatmap-stream

But "event-stream" (which is a dep) requires an earlier version.

The event-stream repo is "archived"https://github.com/dominictarr/event-stream, whcih means we cannot create an issue, but also that we cannot really expect a fix...

Wanted to point out that it is hard coded in this spot as opposed to other places where it comes from the migration contract;

          <tr className={stakeDownClass} >
            <td className={failPrediction}>
              { proposal.state == ProposalStates.PreBoosted
                ? <button onClick={this.showModal.bind(this, 2)}>FAIL +</button>
                : "FAIL"
              }
            </td>
            <td>{proposal.stakesNo} GEN</td>

and here

      <input type="number" min="1" ref={(input) => { this.stakeInput = input; }} className={css.predictionAmount}/>
      <span className={css.genLabel}>GEN</span>
      <div className={css.clearfix}>
        <button className={css.cancelPrediction} onClick={this.closeModal.bind(this)}>
          <img src="/assets/images/Icon/Close-black.svg"/>
        </button>
        <button className={css.placePrediction} onClick={this.handleClickStake.bind(this, showStakeModal)}>Place stake</button>
      </div>

to avoid risk less profit being made by placing a large stake when the casting vote is detected and not yet mined

After npm installing I run, as per instructions:

npm run auto-start-ganache

On first try, it errors, a seond try fails immediately. This is on ubuntu. Tracebacks below:

First time error:

★ npm run auto-start-ganache

> [email protected] auto-start-ganache /media/data2/projects/daostack/alchemy
> run-with-ganache --ganache-cmd ganache-cli "npm run migrate-ganache && npm run start"


> [email protected] migrate-ganache /media/data2/projects/daostack/alchemy
> npm explore @daostack/arc.js -- npm start migrateContracts && npm explore @daostack/arc.js -- npm start createGenesisDao && node ./scripts/mintGen.js


> @daostack/[email protected] start /media/data2/projects/daostack/alchemy/node_modules/@daostack/arc.js
> nps "migrateContracts"

nps is executing `migrateContracts` : node ../../truffle-core-migrate-without-compile/cli migrate --reset --contracts_build_directory migrated_contracts --without-compile --network ganache
Using network 'ganache' (without compile).

Running migration: 1_initial_migration.js
  Deploying Migrations...
  ... 0x0fa8c635495544fe1c6b8accdfc994d4bc847bbda6c6c6291abc60d58ef90ea7
  Migrations: 0x1a6ba4c3194ba8c58e469c5016932115aef79f98
Saving artifacts...
Running migration: 2_deploy_schemes.js
  Running step...
Deploying schemes to ganache
global GEN token does not exist at standard address
global GEN token does not exist in ganache
Creating global GEN token for ganache
  ... undefined
Error encountered, bailing. Network state unknown. Review successful transactions manually.
Error: sender account not recognized
    at Object.InvalidResponse (/media/data2/projects/daostack/alchemy/node_modules/web3/lib/web3/errors.js:38:16)
    at /media/data2/projects/daostack/alchemy/node_modules/web3/lib/web3/requestmanager.js:86:36
    at /media/data2/projects/daostack/alchemy/node_modules/truffle-migrate/index.js:225:11
    at /media/data2/projects/daostack/alchemy/node_modules/truffle-config/node_modules/truffle-provider/wrapper.js:134:9
    at XMLHttpRequest.request.onreadystatechange (/media/data2/projects/daostack/alchemy/node_modules/web3/lib/web3/httpprovider.js:128:7)
    at XMLHttpRequestEventTarget.dispatchEvent (/media/data2/projects/daostack/alchemy/node_modules/xhr2/lib/xhr2.js:64:18)
    at XMLHttpRequest._setReadyState (/media/data2/projects/daostack/alchemy/node_modules/xhr2/lib/xhr2.js:354:12)
    at XMLHttpRequest._onHttpResponseEnd (/media/data2/projects/daostack/alchemy/node_modules/xhr2/lib/xhr2.js:509:12)
    at IncomingMessage.<anonymous> (/media/data2/projects/daostack/alchemy/node_modules/xhr2/lib/xhr2.js:469:24)
    at IncomingMessage.emit (events.js:185:15)
The script called "migrateContracts" which runs "node ../../truffle-core-migrate-without-compile/cli migrate --reset --contracts_build_directory migrated_contracts --without-compile --network ganache" failed with exit code 1 https://github.com/kentcdodds/nps/blob/v5.9.3/other/ERRORS_AND_WARNINGS.md#failed-with-exit-code
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! @daostack/[email protected] start: `nps "migrateContracts"`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the @daostack/[email protected] start script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/jelle/.npm/_logs/2018-10-31T11_26_56_988Z-debug.log
npm ERR! weird error 1
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! [email protected] migrate-ganache: `npm explore @daostack/arc.js -- npm start migrateContracts && npm explore @daostack/arc.js -- npm start createGenesisDao && node ./scripts/mintGen.js`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the [email protected] migrate-ganache script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/jelle/.npm/_logs/2018-10-31T11_26_57_011Z-debug.log

  Command failed: npm run migrate-ganache && npm run start

npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! [email protected] auto-start-ganache: `run-with-ganache --ganache-cmd ganache-cli "npm run migrate-ganache && npm run start"`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the [email protected] auto-start-ganache script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/jelle/.npm/_logs/2018-10-31T11_26_57_051Z-debug.log

Second error:

★ npm run auto-start-ganache

> [email protected] auto-start-ganache /media/data2/projects/daostack/alchemy
> run-with-ganache --ganache-cmd ganache-cli "npm run migrate-ganache && npm run start"


  ganache-cli exited early with code 1

npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! [email protected] auto-start-ganache: `run-with-ganache --ganache-cmd ganache-cli "npm run migrate-ganache && npm run start"`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the [email protected] auto-start-ganache script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/jelle/.npm/_logs/2018-10-31T11_47_53_496Z-debug.log

Not a bug, but confusing: initial state in production is being downloaded from https://s3-us-west-2.amazonaws.com/daostack-alchemy-staging/initialArcState-live.json.
Would be elegant to fix that.

Hey, I am graphic designer and my aim is make my portfolio better with supporting open source project in field of graphic. I can contribute on your project with making a logo design. I would be very pleased if you interested. I am waiting your feedback, have a nice day! :)

Best Regards,
Baran Pirincal
Visual Communication Designer

• Validate forms as the user types/on lost focus (maybe using react-validation or react-validate-form) and display errors.
• Have pending states when waiting for metamask/network.

The auth stuff needs some more configuration of alchemy-server

• set the secrets in .env
• fix the entry.sh script (which currently hangs)
• database tables are not created, it seems (http://127.0.0.1:3001/api/Accounts gives a 500 error, relatuion public.account does not exist)

Currently there can only be one notification appearing at a time, and it disappears upon any action.

Support stacked notification that show transactions status and disappear when the operation is complete, as seen here:

I using alchemy to view my own DAO after I created it with arc.js.
Step by step:

1. I run Ganache standalone
2. Connecting to Ganache using metamask
3. In alchemy project I run npm run migrate-ganache
4. Then npm run start-ganache
5. After I execute migration command in arc.js project npm explore @daostack/arc.js -- npm start migrateContracts
6. Then I created DAO with this code:

DAO created successfully but I can't see my DAO in alchemy, only Genesis  ☹️

p.s.

I submit issue here by request: daostack/arc.js#227 (comment)

We are going to this this as part of alchemy earth. There are two parts to this:

1. save the proposal data in IPFS.
2. read the data from IPFS

saving in ipfs

There is the following PR #206 It still needs some changes, but is a very good start.

The data model is specified here: https://docs.google.com/document/d/1mnhU_L5opxMGuCcdtgOb3D40KX4jquROnx2HvP1qG50/edit

reading from IPFS

This will be done in the subgraph repo, and is tracked in this issue: daostack/subgraph#42

currently the app doesn't behave well on small screens:

Bugs:

1. No visible Version identification
2. When making a new proposal, in both fields of "GEN Reward" and "Reputation Reward" the 0 cannot be deleted without adding another digit.
3. Screen does not get updated if another member votes/makes new proposal unless manual refresh is made.

Requested Features:

1. An indication for un-boosted proposals of how much staking is needed for the threshold of getting boosted
2. Consider a mechanism by which earning from staking is proportional to how early the staking was made (to avoid risk less profit being made by placing a large stake when the casting vote is detected and not yet mined)

npm run test:integration fails on travis.

[this is a discussion issue, to identify potential issues about performance. Once we have actionable items, we can make separate issues]

The problem: the app takes a long time to render.

These ⬇️ give an idea: 20secs to download the data, 40 secs or more to render it (on chrome/debian with superfast internet):

I think to work well on this we'd need some automated tools that tell us the loading time for each build, But we can go for low-hanging fruit first.

Here are some possible things to look at:

• most of the time is spent on rendering. The console.log suggests that there is some unnecessary stuff happing (now way we need to load "Avatar" a 1000 times to render the page):
  . I think here there is most to gain.

• the initial state file is almost 1M. It can be zipped, which will bring it from 1M to 96K.

• the bundle is 1M, which seems a bit big as well.

• we also should look at optimizing the server for the bundle download: it takes a consistent 20s to download that file on my machine, which is way too much.

• now the initial state file is only download AFTER the bundle; this can e done in parallel (i.e. download it in the index.ts or whatever it is called)

Currently can't connect.

If you have no GEN approved, this button appears in the place of GEN stakes.

I think this is bad UX, because:

• the information about what is been staked is interesting for the user, independently of the fact that I can participate or not
• on the boosted proposals, the button is actually misleading, because ven if you "enable predictions", you will not be allowed to predict on them anyway.

Makes more sense to me to prompt the user to approve GEN for staking at the moment that she actually decides to stake, i.e. just show the same UI independently of the pre-approval, and prompt the user at the moment she clicks "pass" or "fail"

this depends on daostack/arc.js#19

Make a version number visible somewhere in the app.

a way for users to search proposals by their title

user story:

• user goes to the alchemy page of a DAO
• a search bar is available on the top part of the page
• a placeholder "search a proposal" text
• user enters search words
• user clicks a "search" button to the right on the search bar
• relevant proposals from both active and history are returned

When I deploy Alchemy to a local testnet (rather then Ganache) I get the following issue;
$ npm explore @daostack/arc.js -- npm start migrateContracts
Deploying ControllerCreator...
... 0xba1723d484bf8cff0a39490e9e0a21c501779f5f8409b2c8c4263743f40c9e72
ControllerCreator: 0x7fa1f52d08e82f91210bb16f45387f2e892fa57e
Deploying DaoCreator...
... 0x9a5dc1b02c5f93b4698b908cf940dc9b73ebdce742140deffc057966fef63612
DaoCreator: 0xc36b8324e6a366ad30c2476b30d9501ba8d3cb0a
Deploying UController...
... undefined
Error encountered, bailing. Network state unknown. Review successful transactions manually.
Error: exceeds block gas limit

Any ideas?

(I think the documentation in Home.md referring to testnets is incomplete; !!! note
See Work with Arc Contracts and Deploy to Other Testnets.

Thanks

to prevent over/underflow

There are some parts of the code where parallization may make loading faster:

@tsuberim wrote:

@jellegerbrandy https://github.com/daostack/alchemy/blob/dev/src/actions/arcActions.ts#L69 Loads DAOs in a sequential order instead of in parallel.

There are some other places where a similar pattern is used and can be parallized, for example in the code that updates the state:

https://github.com/daostack/alchemy/blob/performance/src/components/ViewDao/ViewDaoContainer.tsx#L222
https://github.com/daostack/alchemy/blob/performance/src/components/ViewDao/ViewDaoContainer.tsx#L240

Or the 3 sequential awaits here:

https://github.com/daostack/alchemy/blob/performance/src/layouts/AppContainer.tsx#L109

There may be others...

Once we have #12 and #13, would be great to tie it all together with Travis, and to have it build and deploy the latest master to gh-pages.

Hi. I design a free logo to support projects. I designed one for you. I can give you a gift.

contributionReward.estimate.proposeContributionReward

Should it
what should handle it

the docker setup is at the moment very fragile.

We would like to replace the current two-step setup process (build the dockers; then deploy contracts and configure graphode and other services to use the correct addresses) into one single step (do the configuration in the docker containers).

The project fails to compile after a fresh clone and yarn start with this error:

ERROR in [at-loader] ./src/reducers/arcReducer.ts:91:13
    TS2349: Cannot invoke an expression whose type lacks a call signature. Type 'typeof "/home/matan/Projects/daostack/alchemy/node_modules/immutability-helper/index"' has no compatible call signatures.

ERROR in [at-loader] ./src/reducers/arcReducer.ts:101:14
    TS2349: Cannot invoke an expression whose type lacks a call signature. Type 'typeof "/home/matan/Projects/daostack/alchemy/node_modules/immutability-helper/index"' has no compatible call signatures.

ERROR in [at-loader] ./src/reducers/arcReducer.ts:106:15
    TS2349: Cannot invoke an expression whose type lacks a call signature. Type 'typeof "/home/matan/Projects/daostack/alchemy/node_modules/immutability-helper/index"' has no compatible call signatures.

ERROR in [at-loader] ./src/reducers/arcReducer.ts:113:14
    TS2349: Cannot invoke an expression whose type lacks a call signature. Type 'typeof "/home/matan/Projects/daostack/alchemy/node_modules/immutability-helper/index"' has no compatible call signatures.

ERROR in [at-loader] ./src/reducers/arcReducer.ts:121:14
    TS2349: Cannot invoke an expression whose type lacks a call signature. Type 'typeof "/home/matan/Projects/daostack/alchemy/node_modules/immutability-helper/index"' has no compatible call signatures.
webpack: Failed to compile.

Also, I would suggest using es6 synthax for updating an immutable structure instead of having a dependency:

const x = {a: 1, b: 2};
const y = {...x, b: 3} // {a: 1, b: 3}
// an array would also work.

after refresh I get the "Loading" screen and this error message:

Uncaught (in promise) Error: invalid address
    at inputAddressFormatter (webpack-internal:///./node_modules/web3/lib/web3/formatters.js:274)
    at eval (webpack-internal:///./node_modules/web3/lib/web3/method.js:89)
    at Array.map (<anonymous>)
    at Method.formatInput (webpack-internal:///./node_modules/web3/lib/web3/method.js:88)
    at Method.toPayload (webpack-internal:///./node_modules/web3/lib/web3/method.js:114)
    at Eth.send [as getBalance] (webpack-internal:///./node_modules/web3/lib/web3/method.js:139)
    at eval (webpack-internal:///./src/actions/web3Actions.ts:22)
    at new Promise (<anonymous>)
    at eval (webpack-internal:///./src/actions/web3Actions.ts:12)
    at eval (webpack-internal:///./node_modules/redux-thunk/lib/index.js:11)

(For example) At the moment, if alchemy-server is not responding correctly, the profile page remains on ...loading forever, leaving the user in the dark about the cause.

We'd like something like this:

• if the connection breaks, show thsi immediately
• if the service does not respond, we should show, arfter a reasonable timeout (~5 secs?) an error message: "we could not connect to Alchemy Server, so we cannot get your personal information. You can still use ..."
• in both cases, other, independent, functionality shoudl not break

Alchemy should behave well also when there is no metamask connection. (I.e without information about current account or eth connection provided from metamask)

It could work like this:

1. no metamask, or metamask is locked
   • show information from main chain
   • each user action that requires metamask to be unlocked: onclick = show a message describing problem and solution
2. metamask is present and unlocked.
   • Use (if we can) the network (and account) provided by metamask
3. when user changes metamask connection or acount, the app should update
4. When user locks metamask, revert to first case

A set of hashtags can be associated with each proposal at its creation

to do

• come up with a set of hashtags
• add the ability to add those hashtags during the proposal creation
• add the hashtags to the proposal
• make the hashtags clickable to retrieve all proposals with a given hashtag

These three lines don't work for proposals which ended and are not executed.
We need to "simulate" what would it return if it were executed.

On first page load, there is a delay initializing arc.js. The delay seems a bit onpredicably, but is sometimes considerable (several seconds).

@jellegerbrandy wrote (in issue #194):

more lowhaning fruit: this line https://github.com/daostack/alchemy/blob/dev/src/index.tsx#L18 halts execution until arcjs is initialized. This can take some time, bc the init process also waits for establishing a websocket connection [<- I think] (whcih we are not using), which can take some time.

Solutions here are (a) do not await the initilization (which takes some tricky refactoring) and (b) make the initialization ligher (or the websocket optional) (I don't know about the latter, bc I have not looked yet at what the initilization actually is supposed to do)

@dkent600 replied:

@jellegerbrandy Regarding the call toInitializeArcJs, you should be using the filter configuration setting to speed it up. See here: https://daostack.github.io/arc.js/Configuration/#optimizedcontractloading.

I don't think it is using websockets at all.

What I think we shoudl look at is:

1. Add the filter, as @dkent600 suggests
2. Check out if web3 does not try to open a websocket anyway (my hunch is based on the fact that sometimes the app hands on loading at this point in devtools -> network:
   
3. Check out if we can refactor the loading code and not halt execution while waiting for initializeArcjs.

On startup, we are downloading a 1M file with all initial state data

This file should be compressed, gzip wll bring it to 96K