dapphub / dapple-script Goto Github PK

• How does it look to specify running a function via an interpreter?
• How does it look to mark a function as "atomic only" ?

Currently the real script execution has a step confirmation feature build in: dapple waits after each step before it got included into the chain and the result is the same as the simulated one.
My main motivation was to prevent errors caused by concurrent interaction points from different users as well as prevent a wrong transacton order.
I rediscovered that the later case is irrelevant: the account nonce takes part of this step. So the only reason for it to stay in is to prevent the further execution of the script in case an interaction step is dependant on state, which is also concurrently mutated during the scripts execution.
Is here waiting and aborting the right methodology, or should we deprecate step-confirmation, release all transactions at once, and handle this error case in a different way?

Hey,

I do not really know the code and the execution flow, but in line 56

if(obj.type in opts.classes > -1){
is possibly wrong. In my case obj.type in opts.classes evaluates to false but is interpreted as 0 such that 0 > 1 evaluates to true.

In line 57 opts.classes[obj.type] is referenced, but it can not be part of the object.

After I removed > -1 at least my code was deploying. But as I mentioned I am not really familiar with it. So sorry if I do much ado about very little.