darkere / crashutilities Goto Github PK

https://pastebin.com/w8VvwPWC

1.16.4/35.1.13/crashutilities-3.8a

Hello, just learned about this mod, and i think is awsome.

That said, i'm missing a button to go back a level when looking at individual items or players inventories.

The ability to inspect and manipulate players Ender Chests. Seems fitting for the mod :D

Hello, thanks for fixing item clear - however there seems to now be a server crash after it runs. This has happened just twice this morning and from reports of my users they have said the server seems to crash following an item clear.

Here is the log file from the moment it starts to run..

[21Feb2023 07:42:15.412] [Timer-5/INFO] [net.minecraft.server.MinecraftServer/]: [=== ITEMCLEAR IN 20 SECONDS ===]
[21Feb2023 07:42:15.412] [Server thread/INFO] [net.minecraft.server.MinecraftServer/]: Showing new title for Legend - GeekRiot
[21Feb2023 07:42:25.411] [Timer-3/INFO] [net.minecraft.server.MinecraftServer/]: [=== ITEMCLEAR IN 10 SECONDS ===]
[21Feb2023 07:42:30.411] [Timer-2/INFO] [net.minecraft.server.MinecraftServer/]: [=== ITEMCLEAR IN 5 SECONDS ===]
[21Feb2023 07:42:35.418] [Timer-4/INFO] [net.minecraft.server.MinecraftServer/]: 1573 Items cleared
[21Feb2023 07:42:35.516] [Server thread/ERROR] [net.minecraft.server.MinecraftServer/]: Encountered an unexpected exception
net.minecraft.ReportedException: Ticking entity
	at net.minecraft.server.MinecraftServer.m_5703_(MinecraftServer.java:870) ~[server-1.19.2-20220805.130853-srg.jar%23741!/:?]
	at net.minecraft.server.dedicated.DedicatedServer.m_5703_(DedicatedServer.java:292) ~[server-1.19.2-20220805.130853-srg.jar%23741!/:?]
	at net.minecraft.server.MinecraftServer.m_5705_(MinecraftServer.java:806) ~[server-1.19.2-20220805.130853-srg.jar%23741!/:?]
	at net.minecraft.server.MinecraftServer.m_130011_(MinecraftServer.java:654) ~[server-1.19.2-20220805.130853-srg.jar%23741!/:?]
	at net.minecraft.server.MinecraftServer.m_206580_(MinecraftServer.java:244) ~[server-1.19.2-20220805.130853-srg.jar%23741!/:?]
	at java.lang.Thread.run(Thread.java:833) [?:?]
Caused by: java.util.ConcurrentModificationException
	at java.util.ArrayList$Itr.checkForComodification(ArrayList.java:1013) ~[?:?]
	at java.util.ArrayList$Itr.next(ArrayList.java:967) ~[?:?]
	at com.google.common.collect.Iterators$1.next(Iterators.java:146) ~[guava-31.0.1-jre.jar%2372!/:?]
	at net.minecraft.world.level.entity.EntitySection.m_188352_(EntitySection.java:33) ~[server-1.19.2-20220805.130853-srg.jar%23741!/:?]
	at net.minecraft.world.level.entity.EntitySectionStorage.m_188365_(EntitySectionStorage.java:120) ~[server-1.19.2-20220805.130853-srg.jar%23741!/:?]
	at net.minecraft.world.level.entity.EntitySectionStorage.m_188362_(EntitySectionStorage.java:65) ~[server-1.19.2-20220805.130853-srg.jar%23741!/:?]
	at net.minecraft.world.level.entity.EntitySectionStorage.m_156890_(EntitySectionStorage.java:120) ~[server-1.19.2-20220805.130853-srg.jar%23741!/:?]
	at net.minecraft.world.level.entity.LevelEntityGetterAdapter.m_142232_(LevelEntityGetterAdapter.java:42) ~[server-1.19.2-20220805.130853-srg.jar%23741!/:?]
	at net.minecraft.world.level.Level.m_6249_(Level.java:588) ~[server-1.19.2-20220805.130853-srg.jar%23741!/:?]
	at net.minecraft.world.level.EntityGetter.m_183134_(EntityGetter.java:62) ~[server-1.19.2-20220805.130853-srg.jar%23741!/:?]
	at net.minecraft.world.level.CommonLevelAccessor.m_183134_(CommonLevelAccessor.java:24) ~[server-1.19.2-20220805.130853-srg.jar%23741!/:?]
	at net.minecraft.world.level.CollisionGetter.m_45756_(CollisionGetter.java:57) ~[server-1.19.2-20220805.130853-srg.jar%23741!/:?]
	at net.minecraft.world.entity.item.ItemEntity.m_8119_(ItemEntity.java:122) ~[server-1.19.2-20220805.130853-srg.jar%23741!/:?]
	at net.minecraft.server.level.ServerLevel.track(ServerLevel.java:4740) ~[server-1.19.2-20220805.130853-srg.jar%23741!/:?]
	at net.minecraft.server.level.ServerLevel.redirect$bfe000$onTickNonPassenger(ServerLevel.java:4756) ~[server-1.19.2-20220805.130853-srg.jar%23741!/:?]
	at net.minecraft.server.level.ServerLevel.m_8647_(ServerLevel.java:658) ~[server-1.19.2-20220805.130853-srg.jar%23741!/:?]
	at net.minecraft.world.level.Level.m_46653_(Level.java:457) ~[server-1.19.2-20220805.130853-srg.jar%23741!/:?]
	at net.minecraft.server.level.ServerLevel.m_184063_(ServerLevel.java:323) ~[server-1.19.2-20220805.130853-srg.jar%23741!/:?]
	at net.minecraft.world.level.entity.EntityTickList.m_156910_(EntityTickList.java:54) ~[server-1.19.2-20220805.130853-srg.jar%23741!/:?]
	at net.minecraft.server.level.ServerLevel.m_8793_(ServerLevel.java:303) ~[server-1.19.2-20220805.130853-srg.jar%23741!/:?]
	at net.minecraft.server.MinecraftServer.m_5703_(MinecraftServer.java:866) ~[server-1.19.2-20220805.130853-srg.jar%23741!/:?]
	... 5 more

And here is the crash report
crash-2023-02-21_07.42.35-server.txt

Further information - I found this is a base with a mob farm, and an absorbtion hopper (which is only sucking 1 item at a time it seems).. I do not know for sure but could the hopper be taking the item from the world before the clear runs? Or some other similar conflict?

If possible, could the entities remove command be allowed to remove entities from a specific dim for example...
/cu e remove minecraft:ender_dragon force minecraft:overworld

Been a problem with dragons being glitched into overworld destroy blocks and wanting an easy way to make sure they never enter the overworld without completely disabling the dragon.

Thanks in advanced :)

Im not sure if this is a problem with my game or anything. But when I try to check my memory or view a players inventory it doesn't work. nothing opens or goes into the chat

I suppose I should mention we're playing the ATM6 Modpack so the feature is enabled by default.

CrashUtilities is unloading chunks of entire parties (regardless of who is the owner of that party) when one of the members in that party have been offline for the time set in crashutilities-server.toml.

How to reproduce:

1. Join a private server with a friend.
2. Start a party using FTBTeams, and invite your friend to that party.
3. Claim and load a few chunks. The claim will be owned by the party (and you own that party).
4. Ask your friend to log out for X days, while you keep playing.
5. Log out yourself for a little while (less than 12 hours)
6. Server console will say "Unloading chunks for players not online for X days: YourFriendName"
7. Log back in, all the chunkloads by the party has been removed

Expected result:
CrashUtilities should see that the chunkloading is made by a party, and that the party is still "active" on the server because at least one of the members are still actively playing. Thus it should NOT unload chunks belonging to the party.

Actual result:
CrashUtilities unloads all chunks of a party, and keeps repetedly unloading them, because one of the members of the party has not been online for X days.

Failed to synchronize registry data from server, closing connection

Currently today I've found an issue with this mod force unloading my personal chunks on my server even when I've been actively playing for the past week or so. The issue seems to even persist even while I'm online.

Here are some server logs for reference (they should have timestamps to show the time/date):
https://gist.github.com/ea4ab08a5a31c0623d303969fda92c86

title.

Crash Utilities: 9.0.0
NeoForge: 21.1.49

Crash report: https://gist.githubusercontent.com/Gbergz/3f8102ac39cc01987b2df5fb89b2fd5f/raw/7954b002da91479917b36a7804c2ec7bba54ef77/gistfile1.txt

Title^

MC: 1.20.1
Forge: 47.0.19
Crash Utilities: 8.0.0 | https://legacy.curseforge.com/minecraft/mc-mods/crash-utilities/files/4620856

Logs: https://gist.githubusercontent.com/Gbergz/9fc065763e4398f8257c34425a512a69/raw/48f6a78823fa58876c0be48435c2892e0c7a13e6/gistfile1.txt

Crash-Report: https://gist.githubusercontent.com/Gbergz/a6afd172962d3ffb2dede0bb66a4e5ef/raw/2804ea5b8d707cff7e7b6d809d6543be247b218b/gistfile1.txt

Screenshots:

Notes:
No additional mods added, only Forge(47.0.19) & Crash Utilities installed.

- Gbergz

I added this mod to my server to help out with things and discovered that it will not let the server process to end. If it server crashes, it just sits in a zombie state. If I give it the stop command, it saves and stops what it can, but the server process still continues to run in a zombie state as well.

Either way, I have to kill the server process to allow the server to restart.

I have tested this on a server with just this mod and nothing else and it still acts up.

Hello, I ran into a crash when using the teleport button next to players in this UI : https://cdn.discordapp.com/attachments/410061831198212108/778368845860700213/unknown.png
(It was an offline player if that matters)

Here's the crashlog : https://gist.github.com/jinkhya/8b06ef23b6287005e44a6da3866ff857

Thanks in advance !
Jin

Its tries to run at the threshhold (mines set to 800) but then doesnt clear anything as it says only 3 on ground..

/cu open curios to take that one item the player left on not having to delete it

Currently Crash Utilities crashes on the latest versions of Forge upon startup.

Minecraft Version: 1.19
Forge Version: 41.0.105
Mod Version: 5.0

Crash Log: https://mclo.gs/3LWExSU

It could be really great to have a fabric port for 1.18.2 (and later)

Howdy,
I reported an issue with the player tab last time and I'm not sure i've seen an update fixing it yet. maybe has been and I just didn't realize I updated it but have a new one today.

Hit Control U and it just crashed me right out of my client
crash-2022-10-11_19.30.35-client.txt

Minecraft 1.19.2
Forge 43.1.34
CU: 6.0

`
["Item Clear"]
#Waiting time between Checks in Minutes
#Range: 0 ~ 1440
timer = 4
#Text to display in TitleCommand
titletext = "物品清理"
#Chat warning, Comma separated, in seconds
warnings = "5,20"
#Do a clear if there are more than X items
#Range: > 0
maximum = 500
#Text to Display in Chat when Item. First % will be replaced by Value. In red, encased in [===
warningtext = "% 秒后清理地面物品"
#Run a Title command on first warning
title = true
#Enable regular ItemClear
enabled = false

["Memory Checker"]
#Time between Memory Checks that will get saved for display(in seconds)
#Range: > 0
timer = 300
#Threshold at which the Memory checker will diplay a warning in the Log (in MB)
#Range: > 0
threshold = 500
#Enable the Memory checker
enabled = true

`
This is my configuration file. I've been waiting for a long time without any prompt from the server
Forge：31.1.35

When I opened Crash Utilities and tried to view another player's inventory the client crashed. This is obviously on a server.

Minecraft 1.16.3
Forge 34.0.9
crashutilities-3.4
https://paste.ee/p/jFsLN

I receive a prompt that I need to be an OP whenever I try to bring the GUI up even though I am already an OP. I've tried to deop and reop myself, delete the op.json file on the server then recreate it to make a new one.

The mod was added a week after creating the server. I am running the server on the same computer I am playing on as well.

debug.log

Title^

Crash found in 1.18.2 & 1.19

Versions:
Forge: 41.0.48 & 40.1.48
Minecraft: 1.18.2 & 1.19
Crash Utils: 4.1 & 5.0

Crash-Report: https://gist.github.com/Gbergz/fe4db148456cd2cad3ed916521b6662f

- Gbergz

https://discord.com/channels/792869592267620403/792869720239767635/820245209031245824

After crash utilities installed, the controlling setting menu broken

This happened on both mc1.16.4 and 1.16.5 with crash utilities-3.8.1 and controlling-7.0.0.12

jaredlll08/Controlling#74

Title says it all. When I go in to the entity list with CNTL + U, it gives me the option to delete every entity categorized as a player.

Now, this doesn't result in people being kicked if you do it, but the game starts to behave...weird. Entities stop rendering in. Chunks don't load. Things don't interact with you properly. Notably I found opening doors would result in the top half opening but not the bottom. Interestingly I was still able to open new village chests and have them generate loot.

I might recommend you don't let people remove player entities from the game to prevent this :)

For 1.18.2, I've noticed you're iterating through the world and then through the entities and as you are iterating through the entities you are clearing them which in 1.18.2 is causing a Fast Utilities stack strace in the console.

In my private project I've tested out some fix as I do the same exact thing, I'll share the code here, and let you implement the fix your way :) I do hope it helps.

Using your code for example, when iterating I add the entity to an array and then out side the loop I kill/remove those entities so long as the array is > 0.
This did still work and did as intended while fixing the exception error.

private static int removeEntities(CommandContext<CommandSourceStack> context, ResourceLocation type) {
       counter = 0;
        List<Entity> entities= new ArrayList<>();
        List<ServerLevel> worlds = CommandUtils.getWorlds(context);
        worlds.forEach(world -> world.getEntities().getAll().forEach(e -> {
            if (type == null) {
                if(!entity.hasCustomName()) {
                    entities.add(e);
                }
            }
        }));
        if (entities.size() > 0) {
            entities.forEach(e -> {
                if(!entity.hasCustomName()) {
                    removeEntity(context, world, e);
                    counter++;
                }
            });
        }
}

Take it with a grain of salt, I'm handling it a bit different and just trying to use your code as an exmaple of what it may or may not look like on your end.
Adding to an array and then handling the array outside for each loops works and fixes the FastUtil error from forge that currently is happening with CrashUtilities on 1.18.2.

Using the gui to remove all BE from refined storage for external storage interfaces does not work

This is on the Latest 1.20.1 version

I'm using CrashUtilities-3.8.1
Forge version is 36.0.15

This is my config file: https://gist.github.com/frank89722/7195ab8caa8258960a45440e8c4e7c76

This is what my test world looks like:

The Item clear task never starts even I use 'crashutilities callItemClear' command. There is no chat output and log.

Memory Checker seems like having the same issue.

It makes other configs out of screen.
Can you just put the description in language file or 2 lines?

Would it be possible to have a local GUI that only shows TE and E around the player for loaded chunks the client can see?

It seems most the commands don't work as intended on 1.20.1 build

Running a command /cu be find minecraft:furnace minecraft:overworld
outputs Incorrect argument for command

looking into it a bit more you can't specify the item you want to look for

When using BE and you just do /cu be list minecraft:furnace You will get a list of all BE and hover over will display TE command
That command also says it wants the input of a dim but accepts the input of a BE

It's not possible to search for any BE from refined storage

You can join a server no problem if you relaunch a modpack. But if you happen to relog, with the mod in your client it will throw null point errors and make you have to relaunch to rejoin.

After removing the mod from the client me and a few other people no longer had issues connecting to a server.

Connecting Log to a server
https://gist.github.com/litjohn50/257b40a792bc383c2c06c295d1deeb03