Giter VIP home page Giter VIP logo

atomic-take's People

Stargazers

avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar

Watchers

avatar avatar avatar

Forkers

icodein lucretiel rafalpiotrowski corecode

atomic-take's Issues

Potential to fix memory ordering for taken

atomic-take/src/lib.rs

Lines 150 to 151 in 23d004f

ptr::write(self.value.as_mut_ptr(), value);
*self.taken.get_mut() = false;

Here, token is associated with value that must be synchronized with the access to value, but the code above does not use memory ordering to add reordering constraints. In a multithreaded environment, the following two pieces of code may not be synchronized for the read to value.

atomic-take/src/lib.rs

Lines 117 to 118 in 23d004f

if self.taken.swap(true, Ordering::Relaxed) == false {
unsafe { Some(ptr::read(self.value.as_ptr())) }

atomic-take/src/lib.rs

Lines 163 to 166 in 23d004f

if !*self.taken.get_mut() {
unsafe {
ptr::drop_in_place(self.value.as_mut_ptr());
}

I think atomic operations on token require the use of Acquire/Relase, and modify this code as follows:

ptr::write(self.value.as_mut_ptr(), value); 
self.taken.store(false, Ordering::Release); 

if !self.taken.load(Ordering::Acquire) { 
     unsafe { 
         ptr::drop_in_place(self.value.as_mut_ptr()); 
     }

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.