Giter VIP home page Giter VIP logo

check-pr-fixes-issue's People

Watchers

avatar avatar avatar

Forkers

jstrzebonski

check-pr-fixes-issue's Issues

Fix null error 

Error: TypeError: Cannot read property '0' of null
Error: Cannot read property '0' of null

Accept optional punctuation separating words from issue numbers

Right now, a title #1056: Do stuff is not accepted because the regex looks for a space immediately following the issue number.

I the the regex should be something more like ^#?\d+([:;,/&]?|\s).+$

Similarly, in the body, Fixes: #1056 is not accepted by the check (though it is picked up by Github) because of the :

Check fails if PR title start with #, even though regex seems to allow it?

In VT, when the title ends with a color : (or maybe it's the pound?), it seems to disallow it even though that is supposed to be allowed through the regex. Not sure what is going on there:

check-pr-fixes-issue/tests/helpers.test.js

Lines 27 to 29 in 087ae36

expect(helpers.checkPrTitle("#123 pr title")).toBeTruthy();
expect(helpers.checkPrTitle("#123: pr title")).toBeTruthy();
expect(helpers.checkPrTitle("#123 - pr title")).toBeTruthy(); 

Run DARMA-tasking/check-pr-fixes-issue@master
  with:
    pr_branch: 1075-run-description-when-edited
    pr_title: #1075: Run PR description when edited
    pr_description: Fixes #1075
  
  The check should run when edited now! The default set is:
  
  > By default, a workflow only runs when a pull_request_target's activity type is opened, synchronize, or reopened. To trigger workflows for more activity types, use the types keyword. For more information, see "Workflow syntax for GitHub Actions."
  
  Removing the set made it not run on `edited`. This should fix the problem
##[error]PR title doesn't start with issue number

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.