darsh2 / popularmovies Goto Github PK

View Code? Open in Web Editor NEW

1.0 1.0 2.0 262 KB

Popular Movies Stage - 2

License: Apache License 2.0

Java 100.00%

popularmovies's People

Contributors

Stargazers

Watchers

Forkers

sreereddymenon josecho

popularmovies's Issues

Reviews are not displayed

Steps to reproduce this issue:

Open reviews fragment for any movie say X.
Open many other movie fragments, similar movies, genre movies, change configuration, and so on.
Navigate back.
On reaching X, the reviews that were saved in onSaveInstanceState() return null.

Hence, reviews are not displayed.

Add test cases

Add test cases for checking functionality of various modules as well as UI tests.

Poster and backdrop images don't load

In MovieDetailFragment.java, both poster and backdrop images don't load. Should investigate further to find out cause of issue.

All stars in RatingBar are filled

Irrespective of the rating set, all stars are filled.

App crashes in onSaveInstanceState in FavoriteMoviesFragment

In FavoriteMoviesFragmant, on rotating the device once, followed by rotating it again, the app crashes with the following log:

java.lang.NullPointerException: Attempt to invoke virtual method 'android.support.v7.widget.RecyclerView$LayoutManager com.example.darsh.view.EndlessScrollRecyclerView.getLayoutManager()' on a null object reference
                                                                                     at com.example.darsh.fragment.MoviesListFragment.onSaveInstanceState(MoviesListFragment.java:224)
                                                                                     at android.support.v4.app.Fragment.performSaveInstanceState(Fragment.java:2124)
                                                                                     at android.support.v4.app.FragmentManagerImpl.saveFragmentBasicState(FragmentManager.java:1771)
                                                                                     at android.support.v4.app.FragmentManagerImpl.saveAllState(FragmentManager.java:1839)
                                                                                     at android.support.v4.app.FragmentController.saveAllState(FragmentController.java:134)
                                                                                     at android.support.v4.app.FragmentActivity.onSaveInstanceState(FragmentActivity.java:566)
                                                                                     at android.support.v7.app.AppCompatActivity.onSaveInstanceState(AppCompatActivity.java:492)
                                                                                     at android.app.Activity.performSaveInstanceState(Activity.java:1302)
                                                                                     at android.app.Instrumentation.callActivityOnSaveInstanceState(Instrumentation.java:1290)
                                                                                     at android.app.ActivityThread.callCallActivityOnSaveInstanceState(ActivityThread.java:4122)
                                                                                     at android.app.ActivityThread.handleRelaunchActivity(ActivityThread.java:4084)
                                                                                     at android.app.ActivityThread.-wrap15(ActivityThread.java)
                                                                                     at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1369)
                                                                                     at android.os.Handler.dispatchMessage(Handler.java:102)
                                                                                     at android.os.Looper.loop(Looper.java:148)
                                                                                     at android.app.ActivityThread.main(ActivityThread.java:5461)
                                                                                     at java.lang.reflect.Method.invoke(Native Method)
                                                                                     at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:726)
                                                                                     at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:616)

MovieDetailFragment not recreated correctly

On transitioning from MovieDetailFragment to MovieReviewsFragment and back, the MovieDetailFragment does not display genres, trailers and reviews.

Overview text is not shown

When clicking on a movie from the FavoritesFragment, the overview text is not shown in the MovieDetailsFragment.

ProgressBar not displayed in FooterView

On scrolling to end of current list, more items are to be loaded. While the items are being fetched from tmdb, a footer with a progress bar is to be shown. Some code changes have led to this not being shown.

Fragment is rendered on top existing fragment onOrientationChange

MovieDetailFragment is rendered on top of the existing MovieDetailFragment on changing orientation from current -> inverse -> current.

Reviews RecyclerView is clipped

Steps to reproduce:
In tablet,

Select movie A (preferably one with many reviews such that scrolling is required), open the reviews view
Select another movie B (preferably one with many reviews such that scrolling is required), open the reviews view
Change orientation, movie B reviews are shown completely
Go back to A's review screen. The reviews are clipped here. On orientation change, the reviews are completely visible.

Overview text is clipped

Movie overview text is not shown completely in MovieDetailFragment, despite layout enclosed in a NestedScrollView.

Pages don't load

On repeated and fast switching between portrait and landscape modes, new movie pages don't load after a certain number of pages have been loaded.
This looks like a bug in EndlessScrollerRecyclerView.