:dart: Dart framework for Core Lightning to work with the RPC interface :dart:
Home Page: https://docs.page/dart-lightning/lndart.cln
License: GNU General Public License v2.0
As the notification, we should be able to run a callback when the plugin will subscribe to a hook, in this case, the request contains an id, but it is a hook.
We need to check what is the difference between RPC method and hook in the implementation
The rpc wrapper inside the plugin is useful to give the possibility to call the rpc method if needed (like getinfo from core lightning).
I would like to give this flavor to the user, and maybe we need only to give the user the possibility to run a function of a callback after the init method?
cln is shipping the official rest API and the API looks really nice. It is like our lnlamda.
So we should at some point create another package and support it ElementsProject/lightning#6389
This can cause that out object it not considerer json deserializable, and maybe this spelling can fix our problem.
Integrate the https://github.com/dart-lightning/lndart.cln_grpc package inside the rpc package
When a plugin makes a subscription of notification, the plugin needs to implement a callback to react when the plugin receives a notification.
Please not that the notification is like a RPC method, but core lightning send a request without id
We need to check this with attention with the core lightning docs, with the help of some units tests!
Docs: https://lightning.readthedocs.io/PLUGINS.html#the-getmanifest-method
Improve error handling in the Unix socket
For now, we have the following code
socket.listen((event) {
LogManager.getInstance.debug('Event received is ${utf8.decode(event)}');
completer.complete(utf8.decode(event));
},
onDone: () => LogManager.getInstance.debug('End JSON RPC Stream'),
onError: (err) => LogManager.getInstance.error(err));
We should throw an exception is any error happens inside the onError
Add unit tests to extend the coverage to checking type of the init and manifest fields.
This can be a good first issue, just looking in the Java implementation here, but with the dart code style.
Please open a discussion to talk about the API.
I designed the library like the rust on, and I think that the readme should contain the entry point of each package with a small description
this is the rust example https://github.com/laanwj/rust-clightning-rpc#craters
For this summer of bitcoin @swaptr is the maintainer so :) What do you think?
StackTrace
┌───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
│ #0 LogManager.debug (package:cln_common/src/logger/logger_manager.dart:16:13)
│ #1 new AppChannels.fromJSON (package:clnapp/model/app_model/list_channels.dart:39:28)
├┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄
│ 🐛 {source: 02312627fdf07fbdd7e5ddb136611bdde9b00d26821d14d94891395452f67af248, destination: 02ec99e98f3f3a5e300bebb12a49d5b72d77a55796808a8f5b2e6b42f3db51c7cf, short_channel_id: 2281622x42x1, public: true, satoshis: 20000, amount_msat: 20000000msat, message_flags: 1, channel_flags: 0, active: true, last_update: 1658752225, base_fee_millisatoshi: 1000, fee_per_millionth: 1, delay: 40, htlc_minimum_msat: 1000msat, htlc_maximum_msat: 20000000msat, features: }
└───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
00:46 +2 -2: clnapp unix_client tests API List Channels [E]
type 'String' is not a subtype of type 'Map<String, dynamic>' in type cast
package:clnapp/model/app_model/list_channels.dart 44:9 new AppChannels.fromJSON
package:clnapp/model/app_model/list_channels.dart 15:41 new AppListChannels.fromJSON.<fn>
dart:_internal ListIterable.toList
package:clnapp/model/app_model/list_channels.dart 16:12 new AppListChannels.fromJSON
package:clnapp/api/cln/cln_client.dart 116:53 CLNApi.listChannels.<fn>
package:clightning_rpc/src/clightning_rpc.dart 36:22 RPCClient.call
got some error in calling getInfo method using unixSocket
flutter: │ #0 LogManager.info (package:cln_common/src/logger/logger_manager.dart:24:13)
flutter: │ #1 RPCClient.connect (package:clightning_rpc/src/clightning_rpc.dart:10:10)
flutter: ├┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄
flutter: │ 💡 Connection to JSON RPC 2.0 at the following path /root/.lightning/testnet
flutter: └───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
══╡ EXCEPTION CAUGHT BY WIDGETS LIBRARY ╞═══════════════════════════════════════════════════════════
The following _Exception was thrown building FutureBuilder<AppGetInfo>(dirty, state:
_FutureBuilderState<AppGetInfo>#0554d):
Exception: Converting object to an encodable object failed: Instance of 'JsonRpcMethod'
The relevant error-causing widget was:
FutureBuilder<AppGetInfo>
FutureBuilder:file:///home/kavan/AndroidStudioProjects/lndart.clnapp/lib/views/home/home_view.dart:181:12
When the exception was thrown, this was the stack:
#0 _HomeViewState._checkIfThereAreError (package:clnapp/views/home/home_view.dart:176:7)
#1 _HomeViewState._buildMainView.<anonymous closure> (package:clnapp/views/home/home_view.dart:184:11)
#2 _FutureBuilderState.build (package:flutter/src/widgets/async.dart:615:55)
#3 StatefulElement.build (package:flutter/src/widgets/framework.dart:4919:27)
#4 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:4806:15)
#5 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:4977:11)
#6 Element.rebuild (package:flutter/src/widgets/framework.dart:4529:5)
#7 BuildOwner.buildScope (package:flutter/src/widgets/framework.dart:2659:19)
#8 WidgetsBinding.drawFrame (package:flutter/src/widgets/binding.dart:891:21)
#9 RendererBinding._handlePersistentFrameCallback (package:flutter/src/rendering/binding.dart:370:5)
#10 SchedulerBinding._invokeFrameCallback (package:flutter/src/scheduler/binding.dart:1146:15)
#11 SchedulerBinding.handleDrawFrame (package:flutter/src/scheduler/binding.dart:1083:9)
#12 SchedulerBinding.scheduleWarmUpFrame.<anonymous closure> (package:flutter/src/scheduler/binding.dart:864:7)
(elided 11 frames from class _RawReceivePortImpl, class _Timer, dart:async, and dart:async-patch)
════════════════════════════════════════════════════════════════════════════════════════════════════
We should move this method from private to public, and rename it to confugurePlugin
While I was release the new package I get this failure
NullSafetyCompliance.compliant
Package validation found the following potential issue:
* Please consider renaming /github/workspace/packages/rpc/changelog.json to `CHANGELOG.md`. See https://dart.dev/tools/pub/publishing#important-files.
Maybe we need to change the file name :/
Implementing the log method in the plugin API
We should be include the plugin test inside the integration testing
This will be the my task
══╡ EXCEPTION CAUGHT BY WIDGETS LIBRARY ╞═══════════════════════════════════════════════════════════
The following _Exception was thrown building FutureBuilder<AppGetInfo>(dirty, state:
_FutureBuilderState<AppGetInfo>#4b78e):
Exception: XMLHttpRequest error.
The relevant error-causing widget was:
FutureBuilder<AppGetInfo>
FutureBuilder:file:///home/vincent/Github/dart-lightning/lndart.clnapp/lib/views/home/home_view.dart:228:12
---> 1646ed923722
Step 11/14 : ENV PATH=/opt/clightning-v$CLIGHTNING_VERSION/bin:$PATH
---> Running in 62e372b9421d
Removing intermediate container 62e372b9421d
---> e36e528ca4f0
Step 12/14 : RUN git clone https://github.com/lightningd/plugins.git && cd plugins/commando && pip3 install -r requirements.txt && cd .. && cp -rf commando/ /opt/commando/
---> Running in 70b505105e63
Cloning into 'plugins'...
/bin/sh: 1: cd: can't cd to plugins/commando
The command '/bin/sh -c git clone https://github.com/lightningd/plugins.git && cd plugins/commando && pip3 install -r requirements.txt && cd .. && cp -rf commando/ /opt/commando/' returned a non-zero code: 2
Service 'cln' failed to build : Build failed
This is not too general!
@override
LightningClient connect(String url) {
// TODO: implement connect
throw UnimplementedError();
}
This PR #40 introduce the parsing of the option from the init method, would be cool to add some unit testing!
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
Django
The Web framework for perfectionists with deadlines.
Laravel
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
Microsoft
Open source projects and samples from Microsoft.
Google
Google ❤️ Open Source for everyone.
Alibaba
Alibaba Open Source for everyone
D3
Data-Driven Documents codes.
Tencent
China tencent open source team.