Comments (7)
Created a PR already 🙂
from stylelint-8-point-grid.
Sorry for the late response.
Honestly, I'm not sure how to go about this at first so I search and found this article:
https://builttoadapt.io/8-point-grid-borders-and-layouts-e91eb97f5091?gi=d9953d055d8d
It's a great article and it explain well how to go about border on 8-point grid
I'm leaning towards using the second approach (as said in the article):
allowing the 1px border to hold space outside of the 8px internal padding
So I think there's no need to apply 8 point grid on borders.
Also, by using box-sizing: border-box
, it will include border and padding on final width and height of the element.
from stylelint-8-point-grid.
Also, I think it's uncommon to use large values for border-width
Usually, it's 1px 2px, 4px etc
from stylelint-8-point-grid.
@dcrtantuco, I think I probably understood something wrong then 🙂 Do you mean that at the moment border width will not be affected by the plugin?
from stylelint-8-point-grid.
yes! it doesn't include border width at the moment.
from stylelint-8-point-grid.
@dcrtantuco, cool! thank you for the response! Then I'll close my PR 🙂
from stylelint-8-point-grid.
welcome!
from stylelint-8-point-grid.
Related Issues (11)
- Exclude `line-height` from pattern matching
- Handle or ignore values that uses `calc`
- Support top, right, bottom, and left
- Support calc CSS function and sass variables
- Fix security vulnerability related to js-yaml
- Rename
- Base below 1 no longer allowed (for usage with rems) HOT 10
- Add the feature to add custom properties HOT 4
- Add support for CSS Logical Properties HOT 3
- add support to stylelint 16 bro
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from stylelint-8-point-grid.