Base below 1 no longer allowed (for usage with rems) about stylelint-8-point-grid HOT 10 CLOSED

Interesting! haven't thought of this use case. I agree, let me see what I can do.

from stylelint-8-point-grid.

There seems to be more to this, actually. Apparently rem values are not checked at all, only px values

from stylelint-8-point-grid.

yeah, that's correct. currently, it only checks px values.
thanks for the PR! will check

from stylelint-8-point-grid.

awesome work!
I'll try to finish #22 tomorrow and can probably release new version on Friday.

from stylelint-8-point-grid.

I might tweak the api soon, maybe separate px base from rem base? not yet sure
I just realized if you're using the default config (base: 8)
it will require rem values to be divisible by 8 as well

from stylelint-8-point-grid.

Personally not bothered by that because we just forbid usage of px with another rule. You could define separate ones, but it would require knowledge of the root font size.

from stylelint-8-point-grid.

Personally it would be awesome for me if we could maybe get #25 released before the other changes because I don't know if I'll have time after this week to work on adopting the rule 🙂

from stylelint-8-point-grid.

@felixfbecker done! just published v1.0.0
let me know if it works well

from stylelint-8-point-grid.

looking back, I'm thinking of some improvements, especially handling rem values better
off the top of my head, we can compute rem base from base,
having base 8 will also check if rem values are divisible by 0.5

from stylelint-8-point-grid.

done with the improvements (v2.1.0)
let me know what you think 😄

from stylelint-8-point-grid.