Comments (10)
Interesting! haven't thought of this use case. I agree, let me see what I can do.
from stylelint-8-point-grid.
There seems to be more to this, actually. Apparently rem
values are not checked at all, only px
values
from stylelint-8-point-grid.
yeah, that's correct. currently, it only checks px values.
thanks for the PR! will check
from stylelint-8-point-grid.
awesome work!
I'll try to finish #22 tomorrow and can probably release new version on Friday.
from stylelint-8-point-grid.
I might tweak the api soon, maybe separate px base from rem base? not yet sure
I just realized if you're using the default config (base: 8)
it will require rem values to be divisible by 8 as well
from stylelint-8-point-grid.
Personally not bothered by that because we just forbid usage of px
with another rule. You could define separate ones, but it would require knowledge of the root font size.
from stylelint-8-point-grid.
Personally it would be awesome for me if we could maybe get #25 released before the other changes because I don't know if I'll have time after this week to work on adopting the rule 🙂
from stylelint-8-point-grid.
@felixfbecker done! just published v1.0.0
let me know if it works well
from stylelint-8-point-grid.
looking back, I'm thinking of some improvements, especially handling rem values better
off the top of my head, we can compute rem base from base,
having base 8 will also check if rem values are divisible by 0.5
from stylelint-8-point-grid.
done with the improvements (v2.1.0)
let me know what you think 😄
from stylelint-8-point-grid.
Related Issues (11)
- Support calc CSS function and sass variables
- Fix security vulnerability related to js-yaml
- Support for border in `ignore` HOT 7
- Exclude `line-height` from pattern matching
- Rename
- Add the feature to add custom properties HOT 4
- Add support for CSS Logical Properties HOT 3
- add support to stylelint 16 bro
- Handle or ignore values that uses `calc`
- Support top, right, bottom, and left
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from stylelint-8-point-grid.