Giter VIP home page Giter VIP logo

Comments (3)

railsmith avatar railsmith commented on August 22, 2024

The problem is with the Truncation class which loads the default connection from database.yml rather than preferring the connection from the individual models. Ideally the problem is in the below code:

    # lib/database_cleaner/active_record/truncation.rb

    class Truncation
       include ::DatabaseCleaner::ActiveRecord::Base
       include ::DatabaseCleaner::Generic::Truncation

      def clean
         connection = connection_class.connection
         .... 

After changing it to this.

      # lib/database_cleaner/base.rb

     def clean_with(*args)
      opts = args.pop
      strategy = create_strategy(*args)
      set_strategy_db strategy, self.db

      strategy.clean(opts)
      strategy
    end

     # lib/database_cleaner/active_record/truncation.rb

     def clean(opts = {})
      connection = ActiveRecord::Base.establish_connection(opts).connection
      .....

and changing the configuration into this it is working perfectly fine.

    RSpec.configure do |config|

        config.before(:suite) do
          cleaner = DatabaseCleaner.add_cleaner(:active_record, SQL_SERVER)
          cleaner.clean_with(:truncation, SQL_SERVER)
          DatabaseCleaner.clean_with(:truncation, Rails.configuration.database_configuration[Rails.env])
          DatabaseCleaner.strategy = :transaction
        end

       config.before(:each) do
         DatabaseCleaner.start
       end

      config.after(:each) do
        DatabaseCleaner.clean
      end
   end

from database_cleaner-active_record.

etagwerker avatar etagwerker commented on August 22, 2024

@railsmith I understand the problem. Here is an alternative solution: https://gist.github.com/mgreenly/1109325

I'm not convinced that your solution is the best solution.

If you see the documentation, you can specify a single connection like this: https://github.com/DatabaseCleaner/database_cleaner#how-to-use-with-multiple-orms

I'd be more interested in adding a feature like this:

# for a single connection
DatabaseCleaner[:active_record, { :connection => :two }]

# for multiple connections (this is my proposed solution)
DatabaseCleaner[:active_record, { :connection => [:one, :two] }]

from database_cleaner-active_record.

railsmith avatar railsmith commented on August 22, 2024

@etagwerker

I did not intend to provide the best solution otherwise I would have opened a pull request. I posted the above solution for someone who wants a quick fix by forking the repo and using that fork in an ongoing project. I will open a pull request sometime later.

Thank you for your suggestion.

from database_cleaner-active_record.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.