datadog / trace-examples Goto Github PK

live-server app --port=3000 --mount=/dd-trace:./node_modules/dd-trace/dist --mount=/env:./.env

dd-trace/dd-trace.min.js doesn't load since there is no dist folder in the [email protected] package in node_modules.

Hi DataDog team,

Seems like the https://github.com/DataDog/trace-examples/blob/master/ruby/rails/config/initializers/datadog-tracer.rb

require 'ddtrace'

# Tracing configuration
Rails.configuration.datadog_trace = {
  auto_instrument: true,
  auto_instrument_redis: true,
  auto_instrument_grape: true,
  default_service: ENV['RAILS_SERVICE'] || 'rails-local',
  default_database_service: ENV['RAILS_MYSQL_SERVICE'] || 'db-local',
  default_cache_service: ENV['RAILS_CACHE_SERVICE'] || 'cache-local',
  default_controller_service: ENV['RAILS_CONTROLLER_SERVICE'] || 'controller-local',
  trace_agent_hostname: ENV['DATADOG_TRACER'] || 'datadog'
}

is different from the http://gems.datadoghq.com/trace/docs/#Ruby_on_Rails:

Datadog.configure do |c|
  c.use :rails, options
end

Is the example outdated?

https://ddtrace.readthedocs.io/en/stable/integrations.html#celery says to do patch(celery=True) yet I don't see it in the example. Which one is right? Do both work? 🤔

I tried a similar command to the example:

ddtrace-run celery worker --app ff --loglevel INFO --queues queueName --concurrency 2 --task-events

but I'm not getting any APM data.

I haven't tried patch(celery=True) yet.

This isn't a large issue but did require manual installation of markupsafe in flask example project via:

pipenv install markupsafe

Application ran successfully after that.

As title says I'd like to see a Next.js example so I can be confident I'm instrumenting correctly!

When updating the https://github.com/DataDog/trace-examples/tree/master/python/opentracing/django example to the new Django integration (DataDog/dd-trace-py#1161), we gain visibility but the spans generated from the middleware are not part of the same trace.

Before update:

After update:

But middleware spans are detached from the django.request root:

For execution it says "If you already have datadog agent running as well as ASGI server: uvicorn, you could run: uvicorn app:app." I'm a bit confused by what it means by "datadog agent". Would the datadog daemonset on the same node (deployed by the official datadog helm chart) be enough or should I also prepend the daphne command with ddtrace-run, like so?

ddtrace-run daphne --argsgohere ff.asgi:application

Note that we are using django and the latest version of ddtrace python library and helm chart.