Giter VIP home page Giter VIP logo

Comments (7)

bodiam avatar bodiam commented on July 30, 2024 2

@maxtar It's a bit beyond the scope of this issue, but Java 11 LTS has only but only extended support available, and has been superseded by Java 17 LTS and Java 21, which is also LTS.

Either way, still happy to make a 1.x release when it's fixed.

from datafaker.

bodiam avatar bodiam commented on July 30, 2024 1

Yes to what @snuyanzin said. We don't really support 1.x anymore, nor do we support such old versions of Java, but if you're willing to make a PR for this, I'm happy to release a new 1.x version. But it's recommended to upgrade.

from datafaker.

maxtar avatar maxtar commented on July 30, 2024 1

You could just concatenate the pre/post-fix after generating the regexified value.

I did it. But remove prefix and sufffix before calling regexify.

from datafaker.

snuyanzin avatar snuyanzin commented on July 30, 2024

This is not a datafaker issue, it is the issue of underlying library https://github.com/mifmif/Generex which was used before 2.2.0

Starting 2.2.0 we use another library https://github.com/curious-odd-man/RgxGen
and it doesn't have this problem
So either bump your dependency or contribute a PR to have similar support in 1.x

from datafaker.

maxtar avatar maxtar commented on July 30, 2024

I've got it. But Java 11 is LTS. And we counldn't upgrade to new version now.
I will think about PR thank you.

from datafaker.

kingthorin avatar kingthorin commented on July 30, 2024

You could just concatenate the pre/post-fix after generating the regexified value.

from datafaker.

bodiam avatar bodiam commented on July 30, 2024

Hi @maxtar , we're aware of this issue, and as said before, happy to accept PRs, even on the 1.x branch, but for now I'll close the issue to clean things up a little.

from datafaker.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.