Comments (8)
yes that probably makes sense
why it was done in current way - probably nobody knows since it was done in javafaker first and those contributors are not active in both communities...
I can submit a minimal pull request to demonstrate this approach.
yes,go ahead
The only thing to note since they are public for a long time then first need to mark as deprecated and then remove later
from datafaker.
@asolntsev may be for future: I would suggest squashing commits while merging since it will simplify navigation through commits history
All the highlights could be done in commit message
from datafaker.
If that's the intent then I'm in agreement. I haven't been working on the project long enough to know.
from datafaker.
Makes sense. I don't think we have a super clear agreement about what is our public api vs our more internal. What would you propose to limit the visibility of these methods? Make them package protected? Or something else?
from datafaker.
I think we don't need these methods at all.
What I suggest:
- Remove public methods from
IdNumber
class:public String validMacedonianPersonalCode()
public String invalidMacedonianPersonalCode()
- etc.
- Load all classes like
MacedonianIdNumber
as service providers (a built-in mechanism in Java). Every provider knows what country it's responsible for.
I can submit a minimal pull request to demonstrate this approach.
from datafaker.
@snuyanzin Thanks. Yes, in this case I should squash all commits.
But generally it's not always a good idea. Independent changes should stay in separate commits.
from datafaker.
yep, in generic case it depends on the context
from datafaker.
For my two cents it's the overall contribution that matters to the project not the individual bits of work/correction. So I'm in favour of squash and merge or using amending commits.
from datafaker.
Related Issues (20)
- Add Java 22 to the build matrix. HOT 6
- Adding a Sensor data provider for testing IoT applications HOT 5
- Support JPMS HOT 7
- Extend medical providers to include more medicine-related values HOT 11
- We should support Ollama HOT 2
- Fix address for 'en-NZ' locale
- Using metacharacters on a character set with regexify does not produce the expected text
- v2.2.0: Exceptions when calling certain Faker methods HOT 8
- NullPointerException when using Faker#locality HOT 3
- Unit test failed
- Provide Stream output for transformers HOT 4
- java.lang.RuntimeException: Unable to resolve #{male_first_name} directive for FakerContext HOT 14
- Allow an easy way to create random PII/PHI data HOT 3
- Breaking DateAndTime HOT 4
- Intermitted expressions failures during testing HOT 8
- Regexify method doesn't recognise "^" and "$" chars in datafaker before 2.2.0. HOT 7
- How to specify country-specific setting, not language-specific? HOT 2
- Feature request: add support to generate a random PNG/SVG. HOT 1
- 2.3.0 Release HOT 13
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from datafaker.