European makes and models for cars about datafaker HOT 8 CLOSED

Hi @jaapcoomans , great to see you here. I just had a look at vehicle.yml, and while the list of manufacturers is quite large, the makes and models are not.

I think the best way forward would be to add more makes and models to the vehicle.yml locale, I don't see an issue with that. PR on this certainly welcome!

(I've just added a few Tesla models to the data)

from datafaker.

@snuyanzin in my understanding this is more about updating an existing provider, the Vehicle provider (which is lacking a bit of content) than adding a new provider.

from datafaker.

Hi Jaap, I think we should be good for now? I've also added things like Mazda, Nio, Xpeng, etc, hope that gives a more rich set of data

(#386)

from datafaker.

By the way a few words about how these tasks could be solved

1. A new provider or update an existing one in upstream.
2. datafaker supports custom providers. That means that people don't have to wait for a new release to start use their providers and use it from same datafaker like any other provider. For more info about custom providers please have a look here https://www.datafaker.net/documentation/custom-providers/

And yes contributions are more than welcome

from datafaker.

@bodiam Thanks for thinking along! My question was indeed about extending the Vehicle provider.
I think you're right, adding more makes and models to the vehicle.yaml is the best approach. Expect a PR soon 🙂

Also, TIL that the things I used to call Fakers are actually called Providers. I'll update my vocabulary 👍

from datafaker.

@jaapcoomans Well, you don't have to update your vocabulary, there's not really a clear agreement on them I think. I call Datafaker a faker, and something like a Vehicle thing a provider of data, or, provider in short. But if you want to call it a faker because it generates fake vehicles, I can understand that, I just find it slightly ambiguous when talking about a Faker if we mean the Faker class, or a Data faker, so, Provider it is.

from datafaker.

@jaapcoomans sorry to bother, but any updates on this?

from datafaker.

@bodiam I was afk for a while for various reasons.
But now I have some time at my hand again. PR incoming...

from datafaker.